Properly send custom message in a synchronous manner #1888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
approved these changes
Mar 6, 2025
| "obj": obj, | ||
| } | ||
|
|
||
| self._session._send_message_sync({"custom": {"shinyChatMessage": msg}}) |
There was a problem hiding this comment.
This is def an improvement over .run_coro_sync(), but I'm wondering if we should make .update_user_input() async and escape the possible internal dangers of ._send_message_sync().
There was a problem hiding this comment.
Thanks, we pretty intentionally wanted to try avoiding async since it’s so useful to provide a default value at the top-level.
That said, if it becomes a problem, we could probably add value to .ui() to help with that issue.
schloerke
added a commit
that referenced
this pull request
Mar 10, 2025
* main: fix(textarea-autoresize): add a bit of padding when setting textarea height (#1891) Properly send custom message in a synchronous manner (#1888) fix(page-main-container): Fillable container with min-height/width only when parent layout is fillable (#1885) Add `.latest_stream` to `ui.MarkdownStream()` and deprecate `.get_latest_stream_result()` (#1884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1887