Skip to content

chore!: Add python 3.13 support #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

chore!: Add python 3.13 support #1711

wants to merge 29 commits into from

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Oct 1, 2024 •
edited
Loading

Requires actions/python-versions#308

Python 3.13 has been delayed until 2024-10-07

@schloerke schloerke mentioned this pull request Oct 1, 2024
Merged
schloerke added 12 commits October 1, 2024 16:47
@schloerke
Merge branch 'main' into bump_versions
0ecd6dc
@schloerke
Merge branch 'main' into bump_versions
fe6e2da
@schloerke
Merge branch 'main' into bump_versions
c568fd3 
* main:
  tests(sidebar): Add tests for sidebar (#1715)
  tests(accordion): Add kitchensink tests for accordion (#1710)
  tests(bug): Use locator instead of element handles (#1716)
  tests(deploys): Move import from htmltools into code to help with debugging deploys (#1718)
  build: set Narwhals 1.9.1 as minimum, remove upper bound, use narwhals.stable.v1 for dtypes and typing (#1717)
  feat: support DataFrames via narwhals (#1570)
  Adds Deploy to Connect Cloud buttons to app READMEs (#1709)
@schloerke
Try short version
43fd104
@schloerke
Merge branch 'bump_versions' of https://github.com/posit-dev/py-shiny …
97bba3f 
…into bump_versions
@schloerke
Update pytest.yaml
8f9e8c1
@schloerke
Allow for pre-releases
257f7f6
@schloerke
try using pip for now. Revert commit later!
cf723ec
@schloerke
Revert "try using pip for now. Revert commit later!"
5e7a61c 
This reverts commit cf723ec.
@schloerke
Update playwright as 1.43 depends on greenlet version that is incompa…
62d52ae 
…tible with py3.13
@schloerke
Reapply "try using pip for now. Revert commit later!"
02e8f91 
This reverts commit 5e7a61c.
@schloerke
Revert "Reapply "try using pip for now. Revert commit later!""
70dfdfa 
This reverts commit 02e8f91.
@schloerke
Copy link
Collaborator Author

greenlet is having trouble compiling. Will wait until there is an official 3.13 release. Not too worried as we do not have compiled code.

@schloerke
Copy link
Collaborator Author

greenlet==3.0.3 is required by playwright v1.47.0. As of this comment v1.47.0 is the latest version on PyPI.

microsoft/playwright-python#2589 has been merged to main two days ago adding python 3.13 support and updating greenlet to a python 3.13 compatible version.

This dependency hell is frustrating to deal with as it is out of our control. 🔔 **shame.png

@schloerke
Copy link
Collaborator Author

Getting past playwright, we hit tokenizers failure to build. Related GitHub Issue: huggingface/tokenizers#1639

They're waiting for more upstream changes. ⏳

schloerke
schloerke commented Oct 22, 2024
View reviewed changes
@schloerke schloerke changed the title [WIP] chore!: Drop python 3.8. Add python 3.13 [WIP] chore!: Add python 3.13 support Oct 22, 2024
@gadenbuie gadenbuie added this to the Next Release milestone Feb 19, 2025
@cpsievert
Copy link
Collaborator

cpsievert commented Feb 26, 2025 •
edited
Loading

@schloerke this PR is pretty close to passing, but since modin can't install on 3.13, that leads to some typing issues with data_frame and table tests. Would you be interested in having a pass at resolving those?

@karangattu
Copy link
Collaborator

@schloerke this PR is pretty close to passing, but since modin can't install on 3.13, that leads to some typing issues with data_frame and table tests. Would you be interested in having a pass at resolving those?

This should be resolved now

@schloerke schloerke changed the title [WIP] chore!: Add python 3.13 support chore!: Add python 3.13 support Apr 8, 2025
@schloerke schloerke requested a review from Copilot April 8, 2025 05:21
@schloerke
Copy link
Collaborator Author

schloerke commented Apr 8, 2025 •
edited
Loading

  • Once merged, update the required test to include build-docs (3.13)

Copilot
Copilot AI reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/pytest.yaml:75

  • [nitpick] The step name 'Set up Python 3.10' is misleading given that the test matrix now includes Python 3.13. Consider renaming it to a generic name like 'Set up Python' or dynamically using the version under test.
        - name: "Set up Python 3.10"

@schloerke @Copilot
Skip test w/ modin for anyting >= 3.13
a3f675b 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
4 participants
@schloerke @cpsievert @karangattu @gadenbuie