Flush after output has been recalculated #1361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
flush-after-calculate
branch
from
1387307 to
c9ba49c
Compare
cpsievert
commented
May 7, 2024
cpsievert
commented
May 7, 2024
Comment on lines
+1450
to
+1454
| # Needed so that Shiny knows to flush the outputs. Even if no | ||
| # outputs/errors are queued, it's necessary to flush so that the | ||
| # client knows that progress is over. | ||
| if isinstance(session, AppSession): | ||
| await session._flush() |
There was a problem hiding this comment.
NOTE: this is a bit different from how we handle this in R (via requestFlush()), but we currently don't have a request_flush() in Python
|
See #1360 (comment) (we'll handle the issue in shiny.js, not here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1360