Code

feat: Dynamic theming#1358

Code

Merged

gadenbuie merged 134 commits intomainposit-dev/py-shiny:mainfrom

feat/dynamic-themingposit-dev/py-shiny:feat/dynamic-themingCopy head branch name to clipboard

Jun 27, 2024

Commits

Commits on May 6, 2024

• bump to latest shiny/bslib

  gadenbuie

  committed
  943b48d

  Copy full SHA for 943b48d

• feat: Merge shiny dependencies into a single bootstrap.min.css

  gadenbuie

  committed
  36dc596

  Copy full SHA for 36dc596

• Consolidate all CSS in bootstrap.min.css

  gadenbuie

  committed
  f33a59e

  Copy full SHA for f33a59e

• feat: Add Sass source files for bslib preset themes

  gadenbuie

  committed
  27c6912

  Copy full SHA for 27c6912

• write theme presets into `shiny/ui/_theme_presets.py`

  gadenbuie

  committed
  17eeee7

  Copy full SHA for 17eeee7

• include tuple of preset names for error checking

  gadenbuie

  committed
  7ee9358

  Copy full SHA for 7ee9358

• feat: Dynamic theming with ui.ShinyTheme

  gadenbuie

  committed
  4a67c0b

  Copy full SHA for 4a67c0b

• tests: update example (as demo)

  gadenbuie

  committed
  47d751d

  Copy full SHA for 47d751d

• Include bslib components in base shiny-bootstrap

  Show description for 09d4d60
  gadenbuie

  committed
  09d4d60

  Copy full SHA for 09d4d60

• rename: `ui.Theme`

  gadenbuie

  committed
  2febd00

  Copy full SHA for 2febd00

• update demo

  gadenbuie

  committed
  ec330f2

  Copy full SHA for ec330f2

• rename: shiny:::__SassLayer -> shiny:::__Sass

  gadenbuie

  committed
  b6227d3

  Copy full SHA for b6227d3

• separate sass prep and compilation tasks

  gadenbuie

  committed
  2a92dfb

  Copy full SHA for 2a92dfb

• add comment headings

  gadenbuie

  committed
  6c92ef4

  Copy full SHA for 6c92ef4

• small edits, various

  gadenbuie

  committed
  553cc12

  Copy full SHA for 553cc12

• don't bundle precompiled bootstwatch themes

  gadenbuie

  committed
  195e244

  Copy full SHA for 195e244

• script reports which themes were bundled

  gadenbuie

  committed
  8a74ae8

  Copy full SHA for 8a74ae8

• Add soft-dependency on libsass

  gadenbuie

  committed
  93a8763

  Copy full SHA for 93a8763

Commits on May 7, 2024

• chore: make check-fix

  gadenbuie

  committed
  5a5d1a1

  Copy full SHA for 5a5d1a1

• chore: shiny.express.ui.Theme

  gadenbuie

  committed
  6719bf1

  Copy full SHA for 6719bf1

• chore: also add libsass to dev packages

  gadenbuie

  committed
  e4bd7ad

  Copy full SHA for e4bd7ad

• fix: gitignore folders at the top level

  gadenbuie

  committed
  e2995b9

  Copy full SHA for e2995b9

• Merged origin/main into feat/dynamic-theming

  gadenbuie

  committed
  93f8284

  Copy full SHA for 93f8284

• chore: add comments and some docs

  gadenbuie

  committed
  1c486c4

  Copy full SHA for 1c486c4

• refactor: move all steps to functions

  gadenbuie

  committed
  92d9fcb

  Copy full SHA for 92d9fcb

Commits on May 8, 2024

• refactor: Organize scripts/htmlDependencies into functions

  gadenbuie

  committed
  e7c6189

  Copy full SHA for e7c6189

• refactor: move sass compressed options into individual functions

  gadenbuie

  committed
  fecbdf6

  Copy full SHA for fecbdf6

• refactor: Merge dependency prep into single file

  gadenbuie

  committed
  2bab669

  Copy full SHA for 2bab669

• refactor: align messages, small step order adjustments

  gadenbuie

  committed
  090060a

  Copy full SHA for 090060a

• feat: base Bootstrap for component CSS, Shiny preset for bundled Bootstrap

  gadenbuie

  committed
  ae67027

  Copy full SHA for ae67027

• Merge 'origin/main' into branch 'feat/dynamic-theming'

  gadenbuie

  committed
  f0821ff

  Copy full SHA for f0821ff

• chore: update source of generated file

  gadenbuie

  committed
  b840e15

  Copy full SHA for b840e15

• chore: style scripts to normalize

  gadenbuie

  committed
  1588238

  Copy full SHA for 1588238

• chore: document more functions in setup script

  gadenbuie

  committed
  9bfe679

  Copy full SHA for 9bfe679

• refactor: move setup functions from _deps to _setup

  gadenbuie

  committed
  839e633

  Copy full SHA for 839e633

• docs(Theme): Document class and add two new methods:

  Show description for 350811e
  gadenbuie

  committed
  350811e

  Copy full SHA for 350811e

• tests(Theme): Add tests and fix a few things

  gadenbuie

  committed
  f031e5f

  Copy full SHA for f031e5f

• feat: Bundle page dependencies together without CSS

  Show description for 07f6542
  gadenbuie

  committed
  07f6542

  Copy full SHA for 07f6542

• chore: update shiny.js

  gadenbuie

  committed
  01f3054

  Copy full SHA for 01f3054

• chore: include full version info in script output

  gadenbuie

  committed
  ad9817c

  Copy full SHA for ad9817c

• chore: leave comment about theme extras

  gadenbuie

  committed
  4adbe4a

  Copy full SHA for 4adbe4a

• chore: rename bootstrap version constant

  gadenbuie

  committed
  380f69b

  Copy full SHA for 380f69b

• chore: rename variable to avoid confusion with type

  gadenbuie

  committed
  d00ac20

  Copy full SHA for d00ac20

Commits on May 9, 2024

• feat: add `include_paths` to `Theme` init

  gadenbuie

  committed
  fd5beca

  Copy full SHA for fd5beca

• fix: new tempdir if we need to recompile css

  gadenbuie

  committed
  fa93a08

  Copy full SHA for fa93a08

• refactor: Add `_can_use_precompiled()` method instead of overloading `_css` property

  gadenbuie

  committed
  e4ca799

  Copy full SHA for e4ca799

• chore: `ui.Theme` is an instance of `Tagifiable`

  gadenbuie

  committed
  3774d1c

  Copy full SHA for 3774d1c

• docs: minor edit

  gadenbuie

  committed
  0158012

  Copy full SHA for 0158012

• feat: All `add_*()` methods support kwargs and python -> sass transformation

  gadenbuie

  committed
  8bcc695

  Copy full SHA for 8bcc695

• example: Update api-examples/theme

  gadenbuie

  committed
  2e8e009

  Copy full SHA for 2e8e009

Commits on May 10, 2024

• docs: update example, add local css example

  gadenbuie

  committed
  6565d3d

  Copy full SHA for 6565d3d

• Merged origin/main into feat/dynamic-theming

  gadenbuie

  committed
  8559c54

  Copy full SHA for 8559c54

• tests: Adjust tests of Sass kwarg value handling

  gadenbuie

  committed
  7d2b099

  Copy full SHA for 7d2b099

• feat: Add `compile_args` to `Theme.to_css()`

  Show description for bb492ff
  gadenbuie

  committed
  bb492ff

  Copy full SHA for bb492ff

• temp: Use dev htmltools

  gadenbuie

  committed
  66f91bf

  Copy full SHA for 66f91bf

• chore: remove unused import

  gadenbuie

  committed
  53a8bd0

  Copy full SHA for 53a8bd0

• chore: don't use mutable data structure as default argument

  gadenbuie

  committed
  77e8d85

  Copy full SHA for 77e8d85

• chore: cast to str in place

  gadenbuie

  committed
  feafa64

  Copy full SHA for feafa64

• chore: ignore flake8 warning in one file

  gadenbuie

  committed
  92de33c

  Copy full SHA for 92de33c

• chore: update github ref for py-htmltools

  gadenbuie

  committed
  34f6d87

  Copy full SHA for 34f6d87

• chore: use backwards-compatible NotRequired, TypedDict

  gadenbuie

  committed
  7201607

  Copy full SHA for 7201607

• chore: Use `Union[]` for types

  gadenbuie

  committed
  e78d953

  Copy full SHA for e78d953

• fix(types): Another backcompat type fix

  gadenbuie

  committed
  2b5719a

  Copy full SHA for 2b5719a

• docs: Add css pre-compiling example, add theme to quartodoc index

  gadenbuie

  committed
  1dc7749

  Copy full SHA for 1dc7749

Commits on Jun 13, 2024

• chore: update bslib sass files function name

  gadenbuie

  committed
  2cec3df

  Copy full SHA for 2cec3df

• chore: latest bslib and shiny

  gadenbuie

  committed
  9c4b63c

  Copy full SHA for 9c4b63c

• feat(.add_defaults): Include `!default` flag

  gadenbuie

  committed
  4adbe26

  Copy full SHA for 4adbe26

• refactor: _reset_css() method

  gadenbuie

  committed
  12a6d8c

  Copy full SHA for 12a6d8c

• refactor: `ui.Theme` is not tagifiable, but `theme` can handle it

  gadenbuie

  committed
  3525ade

  Copy full SHA for 3525ade

• tests: fix tests after `!default` flag addition

  gadenbuie

  committed
  784a90e

  Copy full SHA for 784a90e

• feat: Throw if trying to tagify a Theme object

  gadenbuie

  committed
  50f9a45

  Copy full SHA for 50f9a45

• Merge 'origin/main' into feat/dynamic-theming

  gadenbuie

  committed
  1d154c3

  Copy full SHA for 1d154c3

• refactor: `write_spinners_py()`

  gadenbuie

  committed
  adfe7a6

  Copy full SHA for adfe7a6

• tests: Test that htmltools dependency resolution works as expected

  gadenbuie

  committed
  ba2105b

  Copy full SHA for ba2105b

• chore: Leave a note about shiny_page_theme_deps() being for legacy components

  gadenbuie

  committed
  a7b79b8

  Copy full SHA for a7b79b8

• chore: be happy, pyright

  gadenbuie

  committed
  8b1428a

  Copy full SHA for 8b1428a

• feat: Make `ui.Theme` a first class type of the `theme` argument.

  gadenbuie

  committed
  8cf75d4

  Copy full SHA for 8cf75d4

• chore: Use bslib, shiny from main

  gadenbuie

  committed
  6657ac8

  Copy full SHA for 6657ac8

Commits on Jun 14, 2024

• chore: remove requirements.txt from api-examples/theme

  gadenbuie

  committed
  3abdc76

  Copy full SHA for 3abdc76

• chore: Add comment about maker layer location

  gadenbuie

  committed
  04f05f9

  Copy full SHA for 04f05f9

• chore: comment about ionrangeslider

  gadenbuie

  committed
  b067ae0

  Copy full SHA for b067ae0

• refactor: Just extract the contents of `@import "...";`

  gadenbuie

  committed
  7cbd2d7

  Copy full SHA for 7cbd2d7

Commits on Jun 20, 2024

• use released htmltools

  gadenbuie

  committed
  a8e271b

  Copy full SHA for a8e271b

• chore: Remove `**kwargs` from `.add_functions()`

  gadenbuie

  committed
  8591ce3

  Copy full SHA for 8591ce3

• Apply suggestions from code review

  Show description for 587c760
  

  gadenbuie

  and

  cpsievert

  authored
  587c760

  Copy full SHA for 587c760

• chore: remove `dedent_array()`

  gadenbuie

  committed
  3e0d79a

  Copy full SHA for 3e0d79a

• tests: `.add_functions()` doesn't allow kwargs

  gadenbuie

  committed
  8e2d6fa

  Copy full SHA for 8e2d6fa

• chore: don't copy `self._css`

  gadenbuie

  committed
  7010e98

  Copy full SHA for 7010e98

• chore: make `_combine_args_kwargs()` a static method

  gadenbuie

  committed
  75479d7

  Copy full SHA for 75479d7

• Merge 'origin/main' into branch feat/dynamic-theming

  gadenbuie

  committed
  edb6287

  Copy full SHA for edb6287

• docs: Document `compile_args` in `.to_css()` method

  gadenbuie

  committed
  415b9f3

  Copy full SHA for 415b9f3

• chore: Use `tempfile.TemporaryDirectory()`

  gadenbuie

  committed
  7ec2275

  Copy full SHA for 7ec2275

• refactor: Simplify logic of `_html_dependency` method

  gadenbuie

  committed
  d115d03

  Copy full SHA for d115d03

• chore: clean up theme tempdir if `theme` is garbage collected

  Show description for 37be3b5
  gadenbuie

  committed
  37be3b5

  Copy full SHA for 37be3b5

• docs(Theme): Add example

  gadenbuie

  committed
  ab056bb

  Copy full SHA for ab056bb

• fix(add_example): Don't embed files in `.venv` or `venv` directories

  gadenbuie

  committed
  83647e2

  Copy full SHA for 83647e2

• docs: update example to avoid red squiggles

  gadenbuie

  committed
  5530b79

  Copy full SHA for 5530b79

• lint fixes

  gadenbuie

  committed
  f4039e2

  Copy full SHA for f4039e2

• chore: remove unused import

  gadenbuie

  committed
  17343a4

  Copy full SHA for 17343a4

Commits on Jun 21, 2024

• chore: directly link to `sass.compile()`

  gadenbuie

  committed
  6a71999

  Copy full SHA for 6a71999

• docs: Add item to changelog

  gadenbuie

  committed
  89186de

  Copy full SHA for 89186de

• chore: add comment about BS version

  gadenbuie

  committed
  2e8890f

  Copy full SHA for 2e8890f

• chore: Add a check for font import before updating

  Show description for 21fa5e9
  gadenbuie

  committed
  21fa5e9

  Copy full SHA for 21fa5e9

• chore: Add `make upgrade-html-deps` target

  gadenbuie

  committed
  747fb82

  Copy full SHA for 747fb82

• chore: Add tuple of bootstwatch theme names

  gadenbuie

  committed
  df0578b

  Copy full SHA for df0578b

Commits on Jun 24, 2024

• chore: restore bs3compat layer

  Show description for 548782d
  gadenbuie

  committed
  548782d

  Copy full SHA for 548782d

• Merged origin/main into feat/dynamic-theming

  gadenbuie

  committed
  b31011f

  Copy full SHA for b31011f

• fix: remove trailing empty line

  gadenbuie

  committed
  5a6a2ca

  Copy full SHA for 5a6a2ca

• chore: Move some internals into methods

  Show description for dbd989c
  gadenbuie

  committed
  dbd989c

  Copy full SHA for dbd989c

• fix: check that the Theme object has `_css_temp_srcdr` before accessing it.

  gadenbuie

  committed
  eaf3081

  Copy full SHA for eaf3081

• fix: f-string to plain string

  gadenbuie

  committed
  eaedbff

  Copy full SHA for eaedbff

• Merged origin/main into feat/dynamic-theming

  gadenbuie

  committed
  4db16e8

  Copy full SHA for 4db16e8

Commits on Jun 25, 2024

• refactor: Unify into a single HTML dependency method

  Show description for c72c0fd
  gadenbuie

  committed
  c72c0fd

  Copy full SHA for c72c0fd

• test: More testing of css suppression

  gadenbuie

  committed
  be51b0f

  Copy full SHA for be51b0f

• chore: Bump version to 0.10.2.9003

  gadenbuie

  committed
  4616db0

  Copy full SHA for 4616db0

• fix: Make sure `shiny.min.css` isn't included in rendered app HTML

  gadenbuie

  committed
  81f642c

  Copy full SHA for 81f642c

• feat: Mark shiny theme stylesheets with `data-shiny-theme`

  Show description for 36a95fd
  gadenbuie

  committed
  36a95fd

  Copy full SHA for 36a95fd

• fix: ensure theme dependency has valid name

  gadenbuie

  committed
  7bff2d7

  Copy full SHA for 7bff2d7

• fix: Use optional type annotation for older pythons

  gadenbuie

  committed
  6b9ed59

  Copy full SHA for 6b9ed59

• fix: Don't delete tempdir on garbage collection

  Show description for 402399f
  gadenbuie

  committed
  402399f

  Copy full SHA for 402399f

• tests: don't set default value of `theme` in parameterized test

  gadenbuie

  committed
  396105c

  Copy full SHA for 396105c

• Merged origin/main into feat/dynamic-theming

  gadenbuie

  committed
  3f7986a

  Copy full SHA for 3f7986a

• chore: back to `tempfile.mkdtemp()`

  gadenbuie

  committed
  f294093

  Copy full SHA for f294093

Commits on Jun 26, 2024

• Merged origin/main into feat/dynamic-theming

  gadenbuie

  committed
  147364b

  Copy full SHA for 147364b

• Revert "chore: back to `tempfile.mkdtemp()`"

  Show description for 5c90133
  gadenbuie

  committed
  5c90133

  Copy full SHA for 5c90133

• fix: Keep a reference to the tempdir to avoid early garbage collection

  gadenbuie

  committed
  801e52a

  Copy full SHA for 801e52a

• Revert "feat: Mark shiny theme stylesheets with `data-shiny-theme`"

  Show description for 290a8ec
  gadenbuie

  committed
  290a8ec

  Copy full SHA for 290a8ec

• feat: include `data-shiny-theme` attribute in theme stylesheet link tags

  gadenbuie

  committed
  e6819f6

  Copy full SHA for e6819f6

• refactor: Improve/simplify `.to_css(compile_args=)`

  Show description for 95cc53e
  

  gadenbuie

  and

  cpsievert

  committed
  95cc53e

  Copy full SHA for 95cc53e

• fix: include `shiny.css` when Bootstrap is not available

  gadenbuie

  committed
  6a6d508

  Copy full SHA for 6a6d508

• chore: Include express in tagify syntax error message

  gadenbuie

  committed
  a0eaf80

  Copy full SHA for a0eaf80

Commits on Jun 27, 2024

• fix: include shiny.css in page-from-file apps

  gadenbuie

  committed
  dbdb8bd

  Copy full SHA for dbdb8bd

• docs: Add Express option to changelog item

  Show description for d444061
  

  gadenbuie

  and

  cpsievert

  authored
  d444061

  Copy full SHA for d444061

• chore: Add comment about why we check for Bootstrap

  gadenbuie

  committed
  41f4e21

  Copy full SHA for 41f4e21