Skip to content

Make sure ionrangeslider also gets sass options in build script #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Apr 26, 2024

Before this change, it was possible for script/htmlDependencies.R to generate a CSS file for ionrangeslider that included a large embedded source map (when options(shiny.devmode = TRUE)). This will prevent that from happening again

Copy link
Collaborator

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpsievert cpsievert added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 890eda9 Apr 26, 2024
32 checks passed
@cpsievert cpsievert deleted the fix-script-sass-options branch April 26, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants