Skip to content

Bump Ark to 0.1.199 #8629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bump Ark to 0.1.199 #8629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
483f08f
Bump Ark to 0.1.198
lionel- Jul 23, 2025
97cd67e
Bump to Ark 0.1.199
lionel- Jul 24, 2025
e366cc5
Update outline test
lionel- Jul 23, 2025
9c8d131
Only extract symbol name from the outline
lionel- Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/positron-r/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,7 @@
},
"positron": {
"binaryDependencies": {
"ark": "0.1.197"
"ark": "0.1.199"
},
"minimumRVersion": "4.2.0",
"minimumRenvVersion": "1.0.9"
Expand Down
14 changes: 9 additions & 5 deletions test/e2e/pages/outline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,15 @@ export class Outline {
const outllineElements = await this.code.driver.page.locator(OUTLINE_ELEMENT).all();

const outlineData: string[] = [];
for (let i = 0; i < outllineElements.length; i++) {
const element = outllineElements[i];
const text = await element.textContent();
if (text !== null) {
outlineData.push(text);
for (const element of outllineElements) {
// Extract only the symbol name from `.label-name`. We use to extract
// metadata associated to the symbol, but this is too fragile and
// dependent on upstream changes. For instance the number of
// diagnostics/problems may be included there, and other details generated
// by the LSP backend.
const labelName = await element.locator('.label-name').textContent();
if (labelName !== null) {
outlineData.push(labelName.trim());
}
}

Expand Down
13 changes: 6 additions & 7 deletions test/e2e/tests/outline/outline.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,11 @@ test.describe('Outline', { tag: [tags.WEB, tags.WIN, tags.OUTLINE] }, () => {
test('Python - Verify Outline Contents', async function ({ app, python, openFile }) {
await openFile(join('workspaces', 'chinook-db-py', 'chinook-sqlite.py'));
await app.workbench.outline.expectOutlineToContain([
'data_file_pathdata_file_path = os.path.join(os.getcwd(), \'data-files\', \'chinook\', \'chinook.db\')',
'connconn = sqlite3.connect(data_file_path)',
'curcur = conn.cursor()',
'rowsrows = cur.fetchall()',
'dfdf = pd.DataFrame(rows)'
'data_file_path',
'conn',
'cur',
'rows',
'df'
]);
});

Expand All @@ -171,8 +171,7 @@ async function verifyPythonOutline(outline: Outline) {
}

async function verifyROutline(outline: Outline) {
await outline.expectOutlineElementCountToBe(3); // ensure no dupes from multisessions
await outline.expectOutlineElementCountToBe(2); // ensure no dupes from multisessions
await outline.expectOutlineElementToBeVisible('demonstrate_scope');
await outline.expectOutlineElementToBeVisible('global_variable');
await outline.expectOutlineElementToBeVisible('local_variable');
}
Loading