-
Notifications
You must be signed in to change notification settings - Fork 25
chore: update sttp to v4 #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ah I didn't see #416. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename the package to org.polyvariant.sttp4.oauth2(...)
, so that (similarly to sttp itself) it doesn't clash with older versions? On the other hand, I doubt this is used a lot transitively, so having multiple sttp versions on the classpath may not be a likely concern...
@@ -5,4 +5,4 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.4") | |||
addSbtPlugin("org.scalameta" % "sbt-mdoc" % "2.5.4") | |||
addSbtPlugin("com.dwijnand" % "sbt-dynver" % "4.1.1") | |||
addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "1.3.2") | |||
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.16.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please bump sbt-github-actions and regenerate CI, recent runner changes / actions changes must've broken the build. Latest is https://github.com/sbt/sbt-github-actions/releases/tag/v0.25.0 (now published under the com.github.sbt
org)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you'd like, that can be a separate PR. After that (or any other PR) is merged we won't have to approve every CI run from you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped.
I don't think it's necessary but I can do it if you like. Should I? |
I asked @majk-p and we both think it's ok to keep the current state (don't repackage) - let's just resolve CI then |
Thanks for the contribution @agilesteel 💪 |
Any time. I hope I didn't break anything 🙏🏼 |
I also took the liberty to update the sbt and Scala versions.