Skip to content

chore: update sttp to v4 #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

chore: update sttp to v4 #577

merged 1 commit into from
Apr 25, 2025

Conversation

agilesteel
Copy link
Contributor

@agilesteel agilesteel commented Apr 12, 2025

I also took the liberty to update the sbt and Scala versions.

@agilesteel
Copy link
Contributor Author

Ah I didn't see #416.

Copy link
Member

@kubukoz kubukoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the package to org.polyvariant.sttp4.oauth2(...), so that (similarly to sttp itself) it doesn't clash with older versions? On the other hand, I doubt this is used a lot transitively, so having multiple sttp versions on the classpath may not be a likely concern...

@@ -5,4 +5,4 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.4")
addSbtPlugin("org.scalameta" % "sbt-mdoc" % "2.5.4")
addSbtPlugin("com.dwijnand" % "sbt-dynver" % "4.1.1")
addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "1.3.2")
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.16.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump sbt-github-actions and regenerate CI, recent runner changes / actions changes must've broken the build. Latest is https://github.com/sbt/sbt-github-actions/releases/tag/v0.25.0 (now published under the com.github.sbt org)

Copy link
Member

@kubukoz kubukoz Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you'd like, that can be a separate PR. After that (or any other PR) is merged we won't have to approve every CI run from you :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped.

@agilesteel
Copy link
Contributor Author

Should we rename the package to org.polyvariant.sttp4.oauth2(...), so that (similarly to sttp itself) it doesn't clash with older versions? On the other hand, I doubt this is used a lot transitively, so having multiple sttp versions on the classpath may not be a likely concern...

I don't think it's necessary but I can do it if you like. Should I?

@kubukoz
Copy link
Member

kubukoz commented Apr 25, 2025

Should we rename the package to org.polyvariant.sttp4.oauth2(...), so that (similarly to sttp itself) it doesn't clash with older versions? On the other hand, I doubt this is used a lot transitively, so having multiple sttp versions on the classpath may not be a likely concern...

I don't think it's necessary but I can do it if you like. Should I?

I asked @majk-p and we both think it's ok to keep the current state (don't repackage) - let's just resolve CI then

@kubukoz kubukoz merged commit 6bd8165 into polyvariant:main Apr 25, 2025
5 checks passed
@majk-p
Copy link
Member

majk-p commented Apr 25, 2025

Thanks for the contribution @agilesteel 💪

@agilesteel
Copy link
Contributor Author

Thanks for the contribution @agilesteel 💪

Any time. I hope I didn't break anything 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants