decode CBOR's undefined to null #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bleh. We're not going to round-trip this but we shouldn't hit this anyways. Alternatively, we could just return an error. However, that may break things for some users... fixes polydawn#43
|
Ouch 🤕 🌴 I hardly even remember transcribing the "undefined" constant from the spec. I guess this is as reasonable as any other behavior for a value that is, IMO, fundamentally pretty unreasonable... |
|
^ dragged it along in #45 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bleh. We're not going to round-trip this but we shouldn't hit this anyways.
Alternatively, we could just return an error. However, that may break things for some users...
fixes #43
(needs test)