-
Notifications
You must be signed in to change notification settings - Fork 47
Update spec to V5 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update spec to V5 #73
Conversation
| - reserve withdraw: burn local assets and append a `WithdrawAsset` XCM instruction to the | ||
| XCM program to be sent onward to the `destination` location, | ||
|
|
||
| The onward XCM is then appended a `ClearOrigin` to allow safe execution of any following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth to mention here already that ClearOrigin being appended or not depends on preserve_origin flag
| assets are **reserved** for fees, they are sent to the fees register rather than holding. | ||
| Best practice is to only add here enough to cover fees, and transfer the rest through the | ||
| `assets` parameter. | ||
| - `preserve_origin`: Specifies whether the original origin should be preserved or cleared, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its worth to mention that its not actually "original orign" but the sovereign account of original origin on the destination chain
| transferred over to `destination` using the specified transfer type, and deposited to | ||
| holding on `destination`. | ||
| - `remote_xcm`: Custom instructions that will be executed on the `destination` chain. Note | ||
| that these instructions will be executed after a `ClearOrigin` so their origin will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whether its None also depends on preserve_origin
| Operands: | ||
|
|
||
| - `destination`: The location of the program next hop. | ||
| - `remote_fees`: If set to `Some(asset_xfer_filter)`, the single asset matching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also mention that:
- you can set transfer type (same as in
assetscase) separately forremote_fees - you can use
RefundSuprlusto transfer leftovers from fees register to holding register
|
in paragraph 2 https://github.com/polkadot-fellows/xcm-format?tab=readme-ov-file#2-basic-top-level-format
Should we update to 5? |
Including all RFCs that form V5: