Skip to content

refactor: 鉴权插件重构 #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jun 26, 2024
Merged

refactor: 鉴权插件重构 #1357

merged 23 commits into from
Jun 26, 2024

Conversation

chuntaojun
Copy link
Member

Please provide issue(s) of this PR:
Fixes #

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@polaris-test-bot
Copy link

polaris-test-bot commented Jun 12, 2024 •
edited
Loading

2024-06-12 15:26:16: =========TEST START==========
2024-06-14 02:22:03: =========TEST START==========
2024-06-22 17:37:20: =========TEST START==========
2024-06-23 22:59:33: =========TEST START==========
2024-06-24 00:08:53: =========TEST START==========
2024-06-24 01:12:47: =========TEST START==========
2024-06-24 01:36:13: =========TEST START==========
2024-06-24 12:50:17: =========TEST START==========
2024-06-24 14:37:22: =========TEST START==========
2024-06-24 15:55:52: =========TEST START==========
2024-06-25 21:32:39: =========TEST START==========
2024-06-26 12:01:39: =========TEST START==========

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 12, 2024
View reviewed changes
store/mysql/service_contract.go
querySql += fmt.Sprintf(" ORDER BY %s %s LIMIT ?, ? ", filter["order_field"], filter["order_type"])

var count int64
var list = make([]*model.EnrichServiceContract, 0, limit)

Check failure

Code scanning / CodeQL

Slice memory allocation with excessive size value High

This memory allocation depends on a
user-provided value
Loading
.
store/mysql/service_contract.go
}

args = append(args, offset, limit)
rows, err := tx.Query(querySql, args...)

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query depends on a
user-provided value
Loading
.
@chuntaojun chuntaojun merged commit 0cc8c88 into polarismesh:main Jun 26, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chuntaojun @polaris-test-bot