Skip to content

feat:support config empty protection. #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SkyeBeFreeman
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 54.65116% with 39 lines in your changes missing coverage. Please review.

Project coverage is 19.87%. Comparing base (1ca6a8b) to head (c87a9a1).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...guration/client/internal/RemoteConfigFileRepo.java 56.14% 16 Missing and 9 partials ⚠️
...tory/config/configuration/ConnectorConfigImpl.java 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #601      +/-   ##
============================================
- Coverage     20.46%   19.87%   -0.60%     
- Complexity      833      878      +45     
============================================
  Files           334      359      +25     
  Lines         13233    14720    +1487     
  Branches       1702     1839     +137     
============================================
+ Hits           2708     2925     +217     
- Misses        10171    11428    +1257     
- Partials        354      367      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SkyeBeFreeman SkyeBeFreeman force-pushed the m/config-empty-protection branch from 14322a0 to c87a9a1 Compare May 22, 2025 05:22
Copy link
Contributor

@shedfreewu shedfreewu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SkyeBeFreeman SkyeBeFreeman merged commit 030728d into polarismesh:main May 23, 2025
9 of 10 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the m/config-empty-protection branch May 23, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants