Skip to content

feat:optimize heartbeat and re-register. #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

SkyeBeFreeman
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 29.23077% with 46 lines in your changes missing coverage. Please review.

Project coverage is 19.62%. Comparing base (1ca6a8b) to head (50f7ec5).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...is/discovery/client/flow/RegisterStateManager.java 0.00% 29 Missing ⚠️
...nt/polaris/discovery/client/flow/RegisterFlow.java 52.77% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #596      +/-   ##
============================================
- Coverage     20.46%   19.62%   -0.85%     
- Complexity      833      846      +13     
============================================
  Files           334      357      +23     
  Lines         13233    14403    +1170     
  Branches       1702     1798      +96     
============================================
+ Hits           2708     2826     +118     
- Misses        10171    11219    +1048     
- Partials        354      358       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SkyeBeFreeman SkyeBeFreeman force-pushed the m/heartbeat-optimize branch from 7c41728 to 3f1fde4 Compare April 1, 2025 03:40
Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit d0b7f0e into polarismesh:main Apr 7, 2025
9 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the m/heartbeat-optimize branch April 7, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants