Skip to content

#592 重新注册时使用最后一次的注册实例信息 #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jianliu
Copy link
Contributor

@jianliu jianliu commented Mar 28, 2025

#592 每次注册时刷新RegisterState,重新注册时使用最后一次的注册实例信息

Copy link
Member

@SkyeBeFreeman SkyeBeFreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

com.tencent.polaris.discovery.client.flow.RegisterFlow#doRunHeartbeat方法内有心跳失败重注册逻辑,是否需要RegisterStateManager.putRegisterState注册request呢?

Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.57%. Comparing base (1ca6a8b) to head (578188e).
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #595      +/-   ##
============================================
+ Coverage     20.46%   20.57%   +0.11%     
- Complexity      833      839       +6     
============================================
  Files           334      339       +5     
  Lines         13233    13502     +269     
  Branches       1702     1735      +33     
============================================
+ Hits           2708     2778      +70     
- Misses        10171    10370     +199     
  Partials        354      354              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SkyeBeFreeman SkyeBeFreeman force-pushed the main branch 2 times, most recently from 9cc2e2a to 3bb31ea Compare June 10, 2025 03:50
@jianliu
Copy link
Contributor Author

jianliu commented Jun 14, 2025

最后一次注册的request会覆盖前面的instanceRegisterRequest,重注册时用最新的request是符合预期的

@SkyeBeFreeman
Copy link
Member

提交有冲突,先解决冲突。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants