Skip to content

Add some error log when notify error. #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Add some error log when notify error. #594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ...s-discovery-client/src/main/java/com/tencent/polaris/discovery/client/flow/WatchFlow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
*/
public class WatchFlow {

private static final Logger LOG = LoggerFactory.getLogger(SyncFlow.class);
private static final Logger LOG = LoggerFactory.getLogger(WatchFlow.class);
private static final Logger UPDATE_EVENT_LOG = LoggerFactory.getLogger(LOGGING_UPDATE_EVENT_ASYNC);
private static final Map<ServiceKey, Set<ServiceListener>> watchers = new ConcurrentHashMap<>();
private final AtomicBoolean initialize = new AtomicBoolean(false);
Expand Down Expand Up @@ -90,7 +90,13 @@ public WatchServiceResponse commonWatchService(CommonWatchServiceRequest request
.addInstances(Arrays.asList(response.getInstances()))
.allInstances(Arrays.asList(response.getInstances())).build();
firstAddedListeners.forEach(
serviceListener -> executor.execute(event.getServiceKey(), () -> serviceListener.onEvent(event)));
serviceListener -> executor.execute(event.getServiceKey(), () -> {
try {
serviceListener.onEvent(event);
} catch (Throwable e) {
LOG.error("Notify error When listener is first added, service key:{}, event:{}", event.getServiceKey(), event, e);
}
}));
}
boolean result = existListeners.addAll(addListeners);
return new WatchServiceResponse(response, result);
Expand Down Expand Up @@ -168,7 +174,11 @@ private class InstanceChangeListener extends AbstractResourceEventListener {

private final BiConsumer<ServiceChangeEvent, ServiceListener> consumer = (event, listener) -> {
WatchFlow.this.executor.execute(event.getServiceKey(), () -> {
listener.onEvent(event);
try {
listener.onEvent(event);
} catch (Throwable e) {
LOG.error("Notify error, service key:{}, event:{}", event.getServiceKey(), event, e);
}
});
};

Expand Down