Skip to content

feat:support TSF router. #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

SkyeBeFreeman
Copy link
Member

No description provided.

@SkyeBeFreeman SkyeBeFreeman force-pushed the m/router-fault-tolerance branch from 8971a25 to 67961a3 Compare July 11, 2024 12:29
@SkyeBeFreeman SkyeBeFreeman requested a review from andrewshan July 11, 2024 12:42
@SkyeBeFreeman SkyeBeFreeman force-pushed the m/router-fault-tolerance branch 2 times, most recently from aa5f08b to d2a5f1e Compare July 25, 2024 09:46
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 12.43781% with 176 lines in your changes missing coverage. Please review.

Project coverage is 22.68%. Comparing base (2824767) to head (b706623).
Report is 34 commits behind head on main.

Files Patch % Lines
...ava/com/tencent/polaris/api/utils/ApiTrieUtil.java 0.00% 42 Missing ⚠️
.../java/com/tencent/polaris/api/utils/RuleUtils.java 18.75% 21 Missing and 5 partials ⚠️
...in/java/com/tencent/polaris/api/pojo/TrieNode.java 0.00% 17 Missing ⚠️
...gins/connector/grpc/codec/RoutingCacheHandler.java 0.00% 17 Missing ⚠️
...t/polaris/plugins/router/rule/RuleBasedRouter.java 27.27% 12 Missing and 4 partials ⚠️
...tadata/core/constant/tsf/TsfMetadataConstants.java 0.00% 9 Missing ⚠️
...java/com/tencent/polaris/client/flow/BaseFlow.java 0.00% 7 Missing ⚠️
...cent/polaris/api/pojo/DefaultServiceInstances.java 0.00% 7 Missing ⚠️
...ata/core/manager/CalleeMetadataContainerGroup.java 50.00% 4 Missing and 1 partial ⚠️
...java/com/tencent/polaris/api/pojo/HttpElement.java 0.00% 5 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #534      +/-   ##
============================================
- Coverage     24.78%   22.68%   -2.11%     
- Complexity      624      741     +117     
============================================
  Files           196      283      +87     
  Lines          8621    10800    +2179     
  Branches       1115     1374     +259     
============================================
+ Hits           2137     2450     +313     
- Misses         6228     8025    +1797     
- Partials        256      325      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkyeBeFreeman SkyeBeFreeman force-pushed the m/router-fault-tolerance branch 4 times, most recently from 9e0188d to dbf74f5 Compare August 1, 2024 05:47
@SkyeBeFreeman SkyeBeFreeman force-pushed the m/router-fault-tolerance branch 2 times, most recently from 41e5b4a to ce97f65 Compare August 7, 2024 02:33
@SkyeBeFreeman SkyeBeFreeman force-pushed the m/router-fault-tolerance branch from ce97f65 to edddc7a Compare August 8, 2024 03:47
Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit a2a45ed into polarismesh:main Aug 8, 2024
9 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the m/router-fault-tolerance branch August 8, 2024 05:08
SkyeBeFreeman added a commit to SkyeBeFreeman/polaris-java that referenced this pull request Aug 8, 2024
* feat:support TSF router.

* feat:support TSF router.

(cherry picked from commit a2a45ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants