Skip to content

feat:support consul config. #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

SkyeBeFreeman
Copy link
Member

No description provided.

@SkyeBeFreeman SkyeBeFreeman marked this pull request as draft May 23, 2024 14:13
@SkyeBeFreeman SkyeBeFreeman force-pushed the m/consul-config-conn branch 3 times, most recently from 6debf20 to 58e6533 Compare May 24, 2024 05:50
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 1.48515% with 199 lines in your changes missing coverage. Please review.

Project coverage is 23.06%. Comparing base (2824767) to head (1323fab).
Report is 17 commits behind head on main.

Current head 1323fab differs from pull request most recent head 3ee6176

Please upload reports for the commit 3ee6176 to get more accurate results.

Files Patch % Lines
...n/client/internal/ConfigFilePersistentHandler.java 2.17% 135 Missing ⚠️
...tory/config/configuration/ConnectorConfigImpl.java 0.00% 56 Missing ⚠️
...ncent/polaris/api/config/verify/DefaultValues.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #509      +/-   ##
============================================
- Coverage     24.78%   23.06%   -1.73%     
- Complexity      624      702      +78     
============================================
  Files           196      270      +74     
  Lines          8621    10320    +1699     
  Branches       1115     1290     +175     
============================================
+ Hits           2137     2380     +243     
- Misses         6228     7643    +1415     
- Partials        256      297      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkyeBeFreeman SkyeBeFreeman force-pushed the m/consul-config-conn branch 2 times, most recently from 429ba60 to 6cd0beb Compare May 29, 2024 09:23
@SkyeBeFreeman SkyeBeFreeman force-pushed the m/consul-config-conn branch from 5efbcb0 to 552f4e6 Compare June 4, 2024 09:57
@SkyeBeFreeman SkyeBeFreeman marked this pull request as ready for review June 4, 2024 12:11
@SkyeBeFreeman SkyeBeFreeman requested a review from andrewshan June 4, 2024 12:11
Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit be98c31 into polarismesh:main Jun 14, 2024
9 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the m/consul-config-conn branch June 14, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants