-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Upgrade modern carousel to SPFx 1.21.0 #5470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade modern carousel to SPFx 1.21.0 #5470
Conversation
* includes swiper upgrade to latest * changes in gulpfile.js to copy build to temp/build folder * add support for light/dark theme
Sample PR validation for #5470
|
Validation | Status |
---|---|
Pull request affects only one folder | ✅ Succeeded |
Sample folder name follows naming convention | ✅ Succeeded |
Sample requires a .nvmrc file | ✅ Succeeded |
Sample requires a README.md | |
Sample requires a screenshot .png in assets folder | |
No .sppkg file | ✅ Succeeded |
No node_modules folder | ✅ Succeeded |
No lib folder | ✅ Succeeded |
@Sandeep-FED please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.
Sample PR validation for #5470
|
Validation | Status |
---|---|
Pull request affects only one folder | ✅ Succeeded |
Sample folder name follows naming convention | ✅ Succeeded |
README.md contains visitor stat image | |
Sample requires a .nvmrc file | ✅ Succeeded |
Sample requires a README.md | ✅ Succeeded |
Sample requires a screenshot .png in assets folder | ✅ Succeeded |
No .sppkg file | ✅ Succeeded |
No node_modules folder | ✅ Succeeded |
No lib folder | ✅ Succeeded |
@Sandeep-FED please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.
Sample PR validation for #5470✅ Validation status: successWe automatically validate all pull requests against our contribution guidance to ensure that all samples provide a consistent experience to our community. In order to merge this PR in a timely manner, the following criteria must be met:
|
Sample PR validation for #5470✅ Validation status: successWe automatically validate all pull requests against our contribution guidance to ensure that all samples provide a consistent experience to our community. In order to merge this PR in a timely manner, the following criteria must be met:
|
Sample PR validation for #5470✅ Validation status: successWe automatically validate all pull requests against our contribution guidance to ensure that all samples provide a consistent experience to our community. In order to merge this PR in a timely manner, the following criteria must be met:
|
What's in this Pull Request?
This PR includes upgrading of react modern carousel to the latest version of SPFx i.e., 1.21.0. Along with that few cleanups are there related to Swiper library.
Node Version
Node version used: 22.15.0
Checklist
README.md
file's Version history. For new samples, created a newREADME.md
file matching this templateREADME.md
has at least one static high-resolution screenshot (i.e. not a GIF) located in theassets
folder.README.md
contains complete setup instructions, including pre-requisites and permissions required.nvmrc
file indicating the version of Node.js