Skip to content

Fix typo sample.json #5468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Conversation

Sandeep-FED
Copy link
Contributor

What's in this Pull Request?

This PR is to update GitHub username in sample.json author details for two of my samples.

Copy link

Validation failed!

File: samples/react-engage-hub/assets/sample.json

Copy link

Sample PR validation for #5468

⚠️ Validation status: warnings

We automatically validate all pull requests against our contribution guidance to ensure that all samples provide a consistent experience to our community.

In order to merge this PR in a timely manner, the following criteria must be met:

Validation Status
Pull request affects only one folder ⚠️ Warning
Sample folder name follows naming convention ✅ Succeeded
Sample requires a .nvmrc file ⚠️ Warning
Sample requires a README.md ⚠️ Warning
Sample requires a screenshot .png in assets folder ⚠️ Warning
No .sppkg file ✅ Succeeded
No node_modules folder ✅ Succeeded
No lib folder ✅ Succeeded

@Sandeep-FED please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.

@hugoabernier hugoabernier merged commit 25a0d8b into pnp:main May 13, 2025
3 of 4 checks passed
@hugoabernier
Copy link
Collaborator

Many thanks @Sandeep-FED for your update! Much appreciated!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants