Skip to content

Updates spo page section add command with Flexible section. Closes #6742 #6768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mkm17
Copy link
Contributor

@mkm17 mkm17 commented Jun 22, 2025

All changes described in #6742 have been implemented

@milanholemans
Copy link
Contributor

Thanks, we'll try to review it ASAP!

@Adam-it Adam-it self-assigned this Jul 19, 2025
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🤩
tested it locally.
I already have a idea in my head for a scenario for our MCP server to design a page using also flexible layouts now

Comment on lines +294 to 299
if (args.options.sectionTemplate === 'Vertical') {
this.ensureVerticalSectionCanBeAdded(canvasContent);
}


if (!res.IsPageCheckedOutToCurrentUser) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (args.options.sectionTemplate === 'Vertical') {
this.ensureVerticalSectionCanBeAdded(canvasContent);
}
if (!res.IsPageCheckedOutToCurrentUser) {
if (args.options.sectionTemplate === 'Vertical') {
this.ensureVerticalSectionCanBeAdded(canvasContent);
}
if (!res.IsPageCheckedOutToCurrentUser) {

@Adam-it
Copy link
Member

Adam-it commented Jul 19, 2025

ready to merge 🚀 Clean up one break line

@Adam-it
Copy link
Member

Adam-it commented Jul 19, 2025

Merged manually.
Thank you for your contribution. You Rock 🤩

@Adam-it Adam-it closed this Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants