Skip to content

Add TypeScript version rule and tests for project doctor. Closes #6716 #6754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add TypeScript version rule and tests for project doctor. Closes #6716 #6754

wants to merge 5 commits into from

Conversation

nirav-raval
Copy link

Pull Request Title
Adds rule to validate TypeScript dev dependency version. Closes #6716

Linked Issue
Closes #6716

@milanholemans
Copy link
Contributor

Thanks, we'll try to have a look at it ASAP!

@milanholemans
Copy link
Contributor

@nirav-raval, seems like your tests are failing, could you have a look, please? If you need any help, don't hesitate to reach out to us.

@milanholemans milanholemans marked this pull request as draft June 11, 2025 07:32
@nirav-raval
Copy link
Author

@milanholemans Thanks for raising. Checked the test errors in the workflow file, it says node version mismatch. I am using v22.16.0. The contribution guide says to use v20, and the workflow file says to use v22.

Can you guide me on this?

@milanholemans
Copy link
Contributor

We are using v22 for development. The version in the docs is being updated, but that PR still has to be merged yet. Sorry for the inconsistency.

@nirav-raval
Copy link
Author

In this case, would you like me to make any changes on my end?

@milanholemans
Copy link
Contributor

The tests are failing. Are you able to reproduce it locally?

@milanholemans milanholemans marked this pull request as ready for review June 11, 2025 22:24
@nirav-raval
Copy link
Author

@milanholemans Do I need to update anything here?

@milanholemans
Copy link
Contributor

Ni thanks @nirav-raval . If the tests are passing, it's fine. We'll try to review it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans Awaiting requested review from milanholemans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

m365 spfx project doctor should validate typescript version
2 participants
@nirav-raval @milanholemans