Enhances 'spo list view add' with extra types #6746
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the "spo list view add" command by introducing support for additional view types (calendar, gallery, and kanban) and refactoring input validation to use Zod.
- Refactored the command to use Zod-based validation instead of the previous GlobalOptions‐based approach.
- Added new options and corresponding validation for calendar and kanban view types.
- Updated tests and documentation to reflect the newly supported view types.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/m365/spo/commands/list/list-view-add.ts | Updated command implementation with Zod schema; added view type–specific options and validations. |
| src/m365/spo/commands/list/list-view-add.spec.ts | Extended test coverage to validate new options and error scenarios for various view types. |
| docs/docs/cmd/spo/list/list-view-add.mdx | Revised documentation with new options and examples for calendar, gallery, and kanban views. |
milanholemans
force-pushed
the
spo-view-add
branch
from
d3d6c46 to
9533136
Compare
Adam-it
approved these changes
Jul 19, 2025
|
Ready to merge 🚀 |
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6735
As an extra, I've refactored the command to Zod as well.