Skip to content

fix: m365 spo homesite remove fails. Closes #6491 #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: m365 spo homesite remove fails. Closes #6491 #6729

wants to merge 2 commits into from

Conversation

Saurabh7019
Copy link
Contributor

Supports removing a Home Site by URL. When multiple Home Sites are configured, the command shows a deprecation message and removes the first one from the list. Closes #6491

@Saurabh7019 Saurabh7019 marked this pull request as ready for review May 20, 2025 17:05
@milanholemans
Copy link
Contributor

Thanks @Saurabh7019 ! We'll try to look at it ASAP!

@milanholemans milanholemans self-assigned this May 23, 2025
milanholemans
milanholemans requested changes May 24, 2025
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, very much appreciated that you refactored the command to Zod in the meantime!
During my review, I found a few things we'll have to take care of before we get this fix live. Could you give it a check, please?

@milanholemans milanholemans marked this pull request as draft May 24, 2025 22:28
@Saurabh7019 Saurabh7019 marked this pull request as ready for review May 26, 2025 20:44
milanholemans
milanholemans requested changes Jun 15, 2025
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there, let's fix a few more minor issues first.

@milanholemans milanholemans marked this pull request as draft June 15, 2025 17:05
@Saurabh7019 Saurabh7019 marked this pull request as ready for review June 16, 2025 07:53
milanholemans
milanholemans requested changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, let's change two last tiny things before we merge it.

@milanholemans milanholemans marked this pull request as draft July 11, 2025 21:20
@Saurabh7019 Saurabh7019 marked this pull request as ready for review July 12, 2025 04:50
milanholemans
milanholemans approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nothing to add! Will be merged soon.

@milanholemans
Copy link
Contributor

Merged manually, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans milanholemans approved these changes

Assignees

@milanholemans milanholemans

Labels
pr-bugfix pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

m365 spo homesite remove fails
2 participants
@Saurabh7019 @milanholemans