Skip to content

ResourcePacksInfoPacket: Added missing setter #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ResourcePacksInfoPacket: Added missing setter #316

wants to merge 4 commits into from

Conversation

ItzxDwi
Copy link

@ItzxDwi ItzxDwi commented Jun 23, 2025 •
edited
Loading

@ItzxDwi ItzxDwi requested a review from a team as a code owner June 23, 2025 00:12
dktapps
dktapps reviewed Jun 23, 2025
View reviewed changes
@ItzxDwi ItzxDwi requested a review from dktapps June 24, 2025 01:51
@ItzxDwi
Copy link
Author

ItzxDwi commented Jul 14, 2025

someday 🙏

@dktapps
Copy link
Member

dktapps commented Jul 14, 2025

As I mentioned in pmmp/PocketMine-MP#6739, we don't actually need this API since you can just create a new packet and use DataPacketSendEvent::setPackets(). There's some uncertainty within the team about whether to allow mutating this, since we've been moving towards immutable packets for some time now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dktapps dktapps dktapps approved these changes

@ShockedPlot7560 ShockedPlot7560 ShockedPlot7560 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API to control Vibrant Visuals
3 participants
@ItzxDwi @dktapps @ShockedPlot7560