fix: code editor cursor bug #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 19aaa18): https://pluralsh-design--pr717-jake-prod-3908-code-gus261it.web.app (expires Tue, 02 Sep 2025 21:16:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 784914c934330f8d0a9fd65c68898b3988262b7d |
michaeljguarino
approved these changes
Aug 26, 2025
jsladerman
deleted the
jake/prod-3908-code-editor-in-helm-values-input-cursor-position-goofy
branch
|
🎉 This PR is included in version 5.23.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hard to repro consistently, but in various cases the Monaco editor will display the cursor in the wrong place
this is likely caused by something along the lines of our custom font not loading before measuring takes place, so changed it just use a system monospace font
also installed monaco-editor as a dev dependency so we can actually use its typings, and updated wrong types accordingly
also bumped tanstack-virtual dep