fix: icon exports were breaking storybook #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 2fd296e): https://pluralsh-design--pr716-jake-icons-fix-jsfk6rb1.web.app (expires Thu, 14 Aug 2025 18:39:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 784914c934330f8d0a9fd65c68898b3988262b7d |
michaeljguarino
approved these changes
Aug 7, 2025
|
🎉 This PR is included in version 5.23.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the AWS icons don't work the same way as our standard icons, so they were breaking the storybook:
moved them to be exported like a standard component since they already have their own stories
also took out forward ref since we've already migrated to React 19