Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this great little library, I use it often.
Problem
The option to include the number in the output is very convenient.
versus
However most of the time I cannot use this option because I wish to format the number so that it includes grouping separators, to make large numbers much more readable for users.
Proposed Solution
This PR adds support for passing a format function as the
inclusive
parameterOr alternatively, passing an
Intl.NumberFormat
instanceI have:
✅ Updated the JSDoc comments appropriately
✅ Updated Readme with formatting number examples
✅ Added tests which include full coverage for the added lines
Additionally
Despite using this wonderful library for years, I was unaware until now that you could pluralize pronouns. 😮 I don't believe the readme makes this especially obvious, so I added an example to hopefully better highlight this awesome capability.
Thank you for your consideration of this PR. If you agree with these changes I would love to see them published at your earliest convenience. Please let me know if you would like any changes.