Fix(Disk): fix disk space unit #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
waitting customers validation |
Rom1-B
requested changes
May 9, 2025
| $PluginSccmSccmdb = new PluginSccmSccmdb(); | ||
| $res = $PluginSccmSccmdb->connect(); | ||
| if (!$res) { | ||
| die; |
There was a problem hiding this comment.
To avoid Die, maybe you can throw an exception and return false?
There was a problem hiding this comment.
When we migrate the plugin, we will update this section (which is used throughout this class).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Since sccm 2409 (BuildNumber 9132)
TOTAL and FREE disk space is no more in KB but in MB
Screenshots (if appropriate):