Skip to content

fix: location of test db, awaiting strapi teardown #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented Apr 16, 2025

What does it do?

Improves developer experience by putting the temp db in playground/.tmp.
Adds typings to the test/helpers.ts file and adds/removes await where needed.

Why is it needed?

I was trying to figure out where the data was stored while running the tests. This change puts the data in a more visible location. While debugging the tests, I added some typescript typings to the helper file and discovered that some calls were awaited that did not return a promise and one async call was not awaited.

Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: a8c8346

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! As soon as we can confirm the pipeline still works I’ll merge this. Related to my comment on your other pr #262 (review)

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.50%. Comparing base (5db0235) to head (a8c8346).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   42.41%   42.50%   +0.08%     
==========================================
  Files           2        2              
  Lines         639      640       +1     
  Branches      154      154              
==========================================
+ Hits          271      272       +1     
  Misses        293      293              
  Partials       75       75              
Flag Coverage Δ
unit 42.50% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@boazpoolman boazpoolman merged commit a2f2c95 into pluginpal:master Apr 16, 2025
8 checks passed
@jorrit jorrit deleted the testhelper branch April 16, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants