-
-
Notifications
You must be signed in to change notification settings - Fork 790
[Seven] Tutorial, add a likes button #7447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. Most of my suggestions are for the nitpicky s/addon/add-on. The most important one is to use text instead of images of text.
"keywords": "Plone, Project Title, tutorials" | ||
--- | ||
|
||
# Tutorials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YESSSSSS!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. Most of my suggestions are for the nitpicky s/addon/add-on. The most important one is to use text instead of images of text.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two warnings need fixing. I'm not sure if the emoji one can be fixed.
I found a few more addon-name
stragglers, too.
# External Prisma database support for a Seven add-on | ||
|
||
This tutorial will show you how to add a small "Like" counter button to any Seven content object. | ||
It will persist its value in an external database using {term}`Prisma`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a definition in plone/documentation
's glossary before it can be merged. See https://app.readthedocs.org/projects/volto/builds/29831361/#288836463--290.
What is Prisma? I honestly tried to find a definition on Prisma's site, and I fell into a deep rabbit hole of Prisma this-and-that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere in the rush to publish, we missed this bad reference.
https://github.com/plone/volto/actions/runs/18275779783/job/52027479172?pr=7447#step:7:84
* seven: Monorepodocs (#7441) [Seven] Pretty Tailwind (#7434) [Seven] Adding Tailwind to your addon (#7448) [Seven] Added loading of rootLoaderData utilities in the root route (#7449) [Seven] Added registry server loader feature (#7443) Fix providers missing from ESlint config [Seven] Remove all unused imports, due to missing rule (#7395)
@stevepiercy fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending the build and deploy of plone/documentation
so that the glossary term shows up. We'll need to do another build to check https://github.com/plone/volto/actions/runs/18276343014/job/52029237083#step:7:88 is resolved.
@stevepiercy merging, the build looks good now, the glossary term is in place. |
📚 Documentation preview 📚: https://volto--7447.org.readthedocs.build/