Svg improvements, also more verbose images-test page #133
Conversation
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
…oats also use textiowrapper
|
@jenkins-plone-org please run jobs |
|
I have released Meanwhile Jenkins tests fail with: |
jensens
force-pushed
the
svg-improvements
branch
from
68bf74b to
f964aea
Compare
|
@jenkins-plone-org please run jobs |
|
@mauritsvanrees all green now |
Since our last release, we use a function introduced in that version. See #133 (comment)
Branch: refs/heads/main Date: 2025-06-19T12:03:28+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.namedfile@52af470 Require plone.scale 4.2.0 as minimum. Since our last release, we use a function introduced in that version. See plone/plone.namedfile#133 (comment) Files changed: A news/+scale.internal M setup.py Repository: plone.namedfile Branch: refs/heads/main Date: 2025-06-19T12:06:16+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@py76.be> Commit: plone/plone.namedfile@e3b2d58 Merge pull request #183 from plone/maurits-plone-scale-420 Require plone.scale 4.2.0 as minimum. Files changed: A news/+scale.internal M setup.py
Branch: refs/heads/main Date: 2025-06-19T12:03:28+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.namedfile@52af470 Require plone.scale 4.2.0 as minimum. Since our last release, we use a function introduced in that version. See plone/plone.namedfile#133 (comment) Files changed: A news/+scale.internal M setup.py Repository: plone.namedfile Branch: refs/heads/main Date: 2025-06-19T12:06:16+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@py76.be> Commit: plone/plone.namedfile@e3b2d58 Merge pull request #183 from plone/maurits-plone-scale-420 Require plone.scale 4.2.0 as minimum. Files changed: A news/+scale.internal M setup.py
Branch: refs/heads/main Date: 2025-06-19T12:03:28+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.namedfile@52af470 Require plone.scale 4.2.0 as minimum. Since our last release, we use a function introduced in that version. See plone/plone.namedfile#133 (comment) Files changed: A news/+scale.internal M setup.py Repository: plone.namedfile Branch: refs/heads/main Date: 2025-06-19T12:06:16+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@py76.be> Commit: plone/plone.namedfile@e3b2d58 Merge pull request #183 from plone/maurits-plone-scale-420 Require plone.scale 4.2.0 as minimum. Files changed: A news/+scale.internal M setup.py
They are partially wrong, reintroducing the deprecated 'direction' instead of 'mode'. I want to merge the SVG improvements, as I already accidentally made a related change on the main branch.
|
Sorry @jensens, in commit 3dd427d I have undone your changes to the I will merge this one now, to go into Plone 6.1.2. |
need merged and tested with/after merge of plone/plone.scale#68