Remove deprecated plone.app.tiles registry record from the demo profile. #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests breaks because of the new canonical header feature in |
petschki
force-pushed
the
cleanup_registry
branch
from
cd3a7be to
0dd69b2
Compare
|
I've updated the testsetup here #61 with latest plone/meta and rebased this branch. Also removed Plone 5.2 tests ... maybe we should bump the release version to I've also deactivated the breaking tests until the underlying problem is solved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this test failure also happens on master, so might be unrelated to my change.
However - this change is quite unimportant - only cleanup, so that the code stays consistent. I stumbled over it, fixed it along the way and did not expect to be tasked more than 5 minutes on it.
Let's keep it as it is, not merge it until it eventually resolves on its own (or by someone else who is fixing the error on master :)
/cc @petschki