Skip to content

Polyester fixvarious #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2015
Merged

Polyester fixvarious #344

merged 4 commits into from
Aug 13, 2015

Conversation

polyester
Copy link
Member

sorry for the massive commit, I was on a roll a bit. Should dramatically reduce the number of build warnings and errors. Main ones left are

  • the bogus "image not readable' (they are fake because robotframework creates them)
  • ones in /external (should be fixed by authors)
  • and some in buildout.coredev section. Not fixing now because we should pull that in as external as well, I have some pull request there to make that better.

review carefully, there are some editorial decisions in here as well, such as dropping the docs for Linguaplone and raptus.multiplone, with a link to the old docs.

@svx
Copy link
Member

svx commented Aug 12, 2015

@polyester I guess we also have to check which other tickets are may involved into this PR, I konw for example that we have a ticker for LingualPlone #323 .

So we should check the open tickets to and update or if possible close them.

The rest looks awesome thanks a lot !!

@polyester
Copy link
Member Author

Don't merge yet, working on removing more linguaplone stuff (and yakshaving in the process)

@svx
Copy link
Member

svx commented Aug 13, 2015

GO GO GO, just tell me when it is time for review/merge !

@polyester
Copy link
Member Author

There's three mentions of LinguaPlone that I can't take care of, needs somebody with more knowledge. Documented in #323

@polyester
Copy link
Member Author

feel free to review/merge so far; the remaining ones need external review so that could be a while.

@svx
Copy link
Member

svx commented Aug 13, 2015

In:

develop/plone/searching_and_indexing/indexing.rst

and

develop/plone/i18n/internationalisation.rst

we should fix the way how the links are done, currently they are using the 'list at the bottom style' like:

.. _zope.i18n: https://pypi.python.org/pypi/zope.i18n
.. _zope.i18nmessageid: https://pypi.python.org/pypi/zope.i18nmessageid

We should change that into 'in text links', because they are better/easier for translations.

@polyester what is your opinion, do that now, or some day later ?

@polyester
Copy link
Member Author

done for these two. My opinion is about the same as fixing linebreaks: when opportunity arises. One day I will write a shell script to automagically do it. Today is not that day.

but these needed fixing anyway as the links were wrong/outdated/whatever. So good catch

svx pushed a commit that referenced this pull request Aug 13, 2015
@svx svx merged commit 5a784b2 into 5.0 Aug 13, 2015
@svx svx deleted the polyester-fixvarious branch August 13, 2015 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants