-
-
Notifications
You must be signed in to change notification settings - Fork 108
contribute upickle codec #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contribute upickle codec #1164
Conversation
@jam01 Thank you, Jose! You can add your tests as is using Jupiter dependency at least for JVM sub-project. Later I will convert them to scala-test to be runnable on all platforms. |
Added the tests. Hoping they run on CI, not sure if JUnit5 requires further setup in sbt |
@jam01 Could you please fetch upstream & rebase to pick support of Scala Native 0.5? |
Fixed the ujson dependency so the suffix can be replaced by the build framework. Jupiter will continue to fail though. |
Please try |
Just realized I probably should've done a |
A better option would be adding parsing of Let's postpone that for follow up optimizations. |
There is a couple unit test compilation errors yet:
You can reproduce them by |
fixing the jsonassert dependency. The invariant error is strange, because it compiles and passes in my project... 🤔 |
I've changed the base branch to merge and see locally |
Here we go!
I tried to configure the upickle crossProject, but not very familiar with sbt to be honest.
I also took a look at the tests, but that I wasn't sure where/how to start. Here are my tests.