Skip to content

Set the correct status code in case of an invalid 2factor code. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

Set the correct status code in case of an invalid 2factor code. #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/java/com/jongsoft/finance/core/exception/StatusException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ public static StatusException notAuthorized(String message) {
return new StatusException(401, message, null);
}

public static StatusException forbidden(String message) {
return new StatusException(403, message, null);
}

public static StatusException internalError(String message) {
return new StatusException(500, message, null);
}
Expand Down
2 changes: 1 addition & 1 deletion fintrack-api/src/main/java/com/jongsoft/finance/rest/security/MultiFactorResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public MultiFactorResource(
public HttpResponse<?> validateToken(@Valid @Body MultiFactorRequest verification, HttpRequest<?> request) {
var user = currentUserProvider.currentUser();
if (!TwoFactorHelper.verifySecurityCode(user.getSecret(), verification.verificationCode())) {
throw StatusException.notAuthorized("Invalid verification code");
throw StatusException.forbidden("Invalid verification code");
}

var authentication = Authentication.build(
Expand Down