Skip to content

Hotfix/resolve analyze job per user #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025

Conversation

gjong
Copy link
Contributor

@gjong gjong commented Jul 15, 2025

Breaking change

Proposed change

Fix a potential issue where analyze jobs get stuck if one user has sufficient transactions but other users do not. This would currently fail the entire job causing all users to be recomputed.

This fix adds the user to the analyze job and an option to mark them as failed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the application)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
31.7% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@gjong gjong merged commit 753af2f into master Jul 15, 2025
7 of 8 checks passed
@gjong gjong deleted the hotfix/resolve-analyze-job-per-user branch July 15, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant