Retry on 408 timeout from Browserless.io #5800
Open
+43
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertJoonas
approved these changes
Oct 13, 2025
| # rate limit | ||
| 429 -> {:delay, 1000} | ||
| # timeout | ||
| 408 -> {:delay, 500} |
There was a problem hiding this comment.
In detection, given that the endpoint timeout is 5s, and we also delay the retry request by 500ms, I don't think it's realistic that the retry will finish in 500ms. I don't think I ever saw a successful request that fast -- even with a minimal Puppeteer function.
In verification, it could help though.
There was a problem hiding this comment.
You're right, I had deluded myself into thinking maybe. I'll adjust it so 408 is retried in verification.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Starts retrying browserless.io 408 responses again. Experiments show that a request made in quick succession after a 408 timeout can succeed quickly. If it does not, there's now a hard cap on the check itself.
Tests
Changelog
Documentation
Dark mode