Skip to content

Initial UI mock for scriptv2 onboarding #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2025
Merged

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented May 7, 2025

Changes

  • Adds a new scriptv2 feature flag
  • When scriptv2 feature flag is enabled, we redirect user from /:domain/installation to /:domain/installationv2 where new installation screen lives for the time being (to be revisited when ready to launch)
  • New installation screen separates 'optional measurements' and 'advanced options'. Advanced options is collapsed by default.
  • Currently only for manual installation method, will look at switching between installation methods (including new NPM method) in a follow-up PR
  • No concern for different flows at the moment, currently only for provisioning flow. Not sure what will happen to "domain changed" flow and "review" flow on this screen
  • Missing tests at the moment because the main point is to have something tangible in the UI but it's very much subject to change during the course of the project.
  • Doesn't actually do anything - the script config is not saved anywhere.
  • Currently the whole thing is very unfinished but the point is having a UI mock to make progress on the project. Needs many more touches before ready to be used for real

It's nowhere near production-ready and needs lots of extra work. Whether to keep this on a branch or keep merging the WIP is up for discussion.

Screen.Recording.2025-05-07.at.16.31.17.mov

Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You asked for a quick review - this seems like a decent starting point!

@ukutaht ukutaht added this pull request to the merge queue May 19, 2025
Merged via the queue into master with commit 680eaa5 May 19, 2025
8 checks passed
@ukutaht ukutaht deleted the installationv2-screen branch May 19, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants