Added support for grab sampler from comeadhra repository. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psigen
requested changes
Feb 25, 2017
| if (strncmp(param, "temp", 4) == 0){ | ||
| this->setTemp(atof(value)); | ||
| return true; | ||
| if (strncmp(param, "t", 1) == 0){ |
| if (value == NULL) | ||
| { | ||
| char output_str[DEFAULT_BUFFER_SIZE + 3]; | ||
| snprintf(output_str, DEFAULT_BUFFER_SIZE, |
| calibrationStatus | ||
| ); | ||
| send(output_str); | ||
|
|
There was a problem hiding this comment.
Remove whitespace, fix indent (this might be a spaces/tabs mix-- if so, convert everything to spaces).
| this->calibrate(1); | ||
| return true; | ||
| } | ||
| //Serial.println("trigger calibrate method"); |
There was a problem hiding this comment.
Remove this unless we regularly use it for testing.
| return true; | ||
| } | ||
|
|
||
| //Serial.println("trigger calibrate method"); |
There was a problem hiding this comment.
Remove commented print unless regularly used for debugging.
| void AtlasDO::setTemp(double temp) { | ||
| if (temp > 0.0){ | ||
| this->temperature = temp; | ||
| this->temperature = min(temp, 100.0); |
There was a problem hiding this comment.
What's the reason to clamp this? Is there some out-of-range issue we are worried about? Seems bad to not know we are out of range.
|
|
||
| } | ||
|
|
||
| /*void GrabSampler::loop() |
There was a problem hiding this comment.
Remove commented code block unless we plan to use it.
|
|
||
| switch(pump_num) | ||
| { | ||
| case 0: case 1: digitalWrite(board::SENSOR[channel_].GPIO[board::RX_POS], HIGH); analogWrite(board::SENSOR[channel_].GPIO[board::RX_NEG], pump_num == 0 ? 255 : 0); break; |
There was a problem hiding this comment.
Fix indenting/newlines here to look like a normal switch case.
| { | ||
| // init_time = millis(); | ||
|
|
||
| pinMode(board::SENSOR[channel_].GPIO[board::RX_POS], OUTPUT); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs testing but should be ok to merge into Master.