Skip to content

Conversation

@taslangraham
Copy link
Contributor

<div
v-if="item.affiliation || item.orcid"
v-if="item.affiliation"
class="listPanel__item--reviewer__affiliation"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @taslangraham , I tested this on storybook and your fix works.
Just thought that we should address the long affiliation names. Currently, the rest of the text disappears:
image

We can fix this by adding these classes:

Suggested change
class="listPanel__item--reviewer__affiliation"
class="listPanel__item--reviewer__affiliation whitespace-normal break-words"

Then the affiliation name will render like this:
image

<div class="listPanel__itemSubtitle">
<div
v-if="item.affiliation || item.orcid"
class="listPanel__itemSubtitle"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Follow up on my previous comment)
I see that we intentionally set these rules to the parent container:

.listPanel__itemTitle,
.listPanel__itemSubtitle {
	white-space: nowrap;
	overflow: hidden;
	text-overflow: ellipsis;
}

Instead of adding the whitespace-normal break-words, we can just remove the listPanel__itemSubtitle class so complete text will always be displayed on the child elements.

Suggested change
class="listPanel__itemSubtitle"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants