sig-docs: promote breeswish to committer #336

ran-huang · 2020-11-06T04:59:54Z

@breeswish has contributed a lot to Docs SIG. According to Be promoted to Committer
, we would like to promote him to a new committer of Docs SIG. His detailed contribution is shown below:

Have reviewed 46 PRs in docs repo within the past one year
Helped resolve 1 issue
Added a script to verify link anchors in the docs-cn repo (a big feature)
Sponsored by two incumbent committers: @ran-huang, @TomShawn

ghost · 2020-11-06T04:59:57Z

Sig file formatting success.

ran-huang · 2020-11-06T05:00:20Z

/cc @lilin90, @yikeke

lilin90 · 2020-11-06T05:32:46Z

special-interest-groups/sig-docs/membership.md

@@ -15,8 +15,12 @@

 ## Committers

+* [3pointer](https://github.com/3pointer)
+* [amyangfei](https://github.com/amyangfei)
+* [breeswish](https://github.com/breeswish)


I agree with promoting breeswish & amyangfei to committers this time and expect other candidates to have a better command of both Chinese and English technical writing and documentation rules.

ghost · 2020-11-06T05:42:29Z

The membership must be a json file.

Details

Tip :
You should migrate the current file to a json file, the file format is as follows:

{
  "type": "object",
  "required": [
      "name",
      "techLeaders",
      "committers",
      "reviewers",
      "activeContributors"
  ],
  "properties": {
      "name": {
          "type": "string"
      },
      "techLeaders": {
          "type": "array",
          "items": {
              "type": "object",
              "required": [
                  "githubName"
              ],
              "properties": {
                  "githubName": {
                      "type": "string"
                  }
              }
          }
      },
      "coLeaders": {
          "type": "array",
          "items": {
              "type": "object",
              "required": [
                  "githubName"
              ],
              "properties": {
                  "githubName": {
                      "type": "string"
                  }
              }
          }
      },
      "committers": {
          "type": "array",
          "items": {
              "type": "object",
              "required": [
                  "githubName"
              ],
              "properties": {
                  "githubName": {
                      "type": "string"
                  }
              }
          }
      },
      "reviewers": {
          "type": "array",
          "items": {
              "type": "object",
              "required": [
                  "githubName"
              ],
              "properties": {
                  "githubName": {
                      "type": "string"
                  }
              }
          }
      },
      "activeContributors": {
          "type": "array",
          "items": {
              "type": "object",
              "required": [
                  "githubName"
              ],
              "properties": {
                  "githubName": {
                      "type": "string"
                  }
              }
          }
      }
  }
}

Warning: None

ghost · 2020-11-06T05:43:52Z

The membership must be a json file.

Details

Tip :
You should migrate the current file to a json file, the file format is as follows:

{
  "type": "object",
  "required": [
      "name",
      "techLeaders",
      "committers",
      "reviewers",
      "activeContributors"
  ],
  "properties": {
      "name": {
          "type": "string"
      },
      "techLeaders": {
          "type": "array",
          "items": {
              "type": "object",
              "required": [
                  "githubName"
              ],
              "properties": {
                  "githubName": {
                      "type": "string"
                  }
              }
          }
      },
      "coLeaders": {
          "type": "array",
          "items": {
              "type": "object",
              "required": [
                  "githubName"
              ],
              "properties": {
                  "githubName": {
                      "type": "string"
                  }
              }
          }
      },
      "committers": {
          "type": "array",
          "items": {
              "type": "object",
              "required": [
                  "githubName"
              ],
              "properties": {
                  "githubName": {
                      "type": "string"
                  }
              }
          }
      },
      "reviewers": {
          "type": "array",
          "items": {
              "type": "object",
              "required": [
                  "githubName"
              ],
              "properties": {
                  "githubName": {
                      "type": "string"
                  }
              }
          }
      },
      "activeContributors": {
          "type": "array",
          "items": {
              "type": "object",
              "required": [
                  "githubName"
              ],
              "properties": {
                  "githubName": {
                      "type": "string"
                  }
              }
          }
      }
  }
}

Warning: None

0xPoe · 2020-11-06T08:48:57Z

Please waiting this issue ti-community-infra/ti-community-bot#107 fixed.

lilin90

LGTM

ti-chi-bot · 2020-11-06T09:01:44Z

@lilin90: adding LGTM is restricted to reviewers in list.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

0xPoe · 2020-11-09T06:45:34Z

Please waiting this issue tidb-community-bots/ti-community-bot#107 fixed.

Already fixed. @ran-huang Please resolve the conflicts.

ghost · 2020-11-09T08:07:29Z

Cannot modify multiple sig info files in one PR.

Signed-off-by: Ran <huangran@pingcap.com>

ghost · 2020-11-09T09:04:41Z

Cannot modify multiple sig info files in one PR.

ghost · 2020-11-09T09:06:46Z

Sig file formatting success.

ran-huang · 2020-11-09T09:20:27Z

/merge

ti-chi-bot · 2020-11-09T09:20:29Z

@ran-huang: you cannot merge your own PR.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

0xPoe · 2020-11-09T09:22:52Z

@pingcap/tidb-maintainer

Only the maintainer can approve the PR for adding a committer.
About the permission design you can refer to this doc.

And about the ti-community-prow-bot you can refer to the prow bot book.

0xPoe · 2020-11-09T09:23:05Z

/cc @pingcap/tidb-maintainer

ti-chi-bot · 2020-11-09T09:23:06Z

@hi-rustin: GitHub didn't allow me to request PR reviews from the following users: pingcap/tidb-maintainer.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pingcap/tidb-maintainer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ran-huang · 2020-11-12T08:42:00Z

/cc @pingcap/tidb-maintainer

ti-chi-bot · 2020-11-12T08:42:02Z

@ran-huang: GitHub didn't allow me to request PR reviews from the following users: pingcap/tidb-maintainer.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pingcap/tidb-maintainer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ran-huang · 2020-11-12T08:48:13Z

@AndreMouche PTAL. This PR needs LGTM from maintainers.

AndreMouche · 2020-11-15T12:08:41Z

@AndreMouche PTAL. This PR needs LGTM from maintainers.

Could you please explain the reason for example #330

Signed-off-by: Ran <huangran@pingcap.com>

ran-huang · 2020-11-16T03:14:28Z

@breeswish has contributed a lot to Docs SIG. According to Be promoted to Committer
, we would like to promote him to a new committer of Docs SIG. His detailed contribution is shown below:

Have reviewed 46 PRs in docs repo within the past one year
Helped resolve 1 issue
Added a script to verify link anchors in the docs-cn repo (a big feature)
Sponsored by two incumbent committers: @ran-huang, @TomShawn

@AndreMouche PTAL. Do we need detailed reasons for active contributors?

Signed-off-by: Ran <huangran@pingcap.com>

winkyao

LGTM

0xPoe · 2020-11-20T03:42:38Z

@winkyao You should approve it not just comment.

About LGTM, you can refer to https://book.prow.tidb.io/plugins/lgtm.html#%E5%AE%9E%E7%8E%B0%E6%80%9D%E8%B7%AF

jackysp

LGTM

ghost · 2020-11-23T02:26:40Z

Update sig info success.

lilin90 reviewed Nov 6, 2020

View reviewed changes

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2020

lilin90 approved these changes Nov 6, 2020

View reviewed changes

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2020

ran-huang added 2 commits November 9, 2020 16:47

sig-docs: update membership

172a26e

Signed-off-by: Ran <huangran@pingcap.com>

resolve conflict

1787793

Signed-off-by: Ran <huangran@pingcap.com>

ran-huang force-pushed the sig-docs-1106 branch from 4f7f104 to 1787793 Compare November 9, 2020 09:04

Delete membership.md

6822c0f

revert a committer promotion

5c4562d

Signed-off-by: Ran <huangran@pingcap.com>

fix format

79cca05

Signed-off-by: Ran <huangran@pingcap.com>

AndreMouche changed the title ~~sig-docs: update membership~~ sig-docs: promote breeswish to committer Nov 19, 2020

winkyao reviewed Nov 20, 2020

View reviewed changes

winkyao approved these changes Nov 20, 2020

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2020

jackysp reviewed Nov 23, 2020

View reviewed changes

winkyao merged commit bd52402 into pingcap:master Nov 23, 2020

ran-huang deleted the sig-docs-1106 branch November 23, 2020 02:32

sig-docs: promote breeswish to committer #336

sig-docs: promote breeswish to committer #336

Uh oh!

Conversation

ran-huang commented Nov 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Nov 6, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ran-huang commented Nov 6, 2020

Uh oh!

lilin90 Nov 6, 2020

Choose a reason for hiding this comment

Uh oh!

ran-huang Nov 6, 2020

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 6, 2020

Uh oh!

ghost commented Nov 6, 2020

Uh oh!

0xPoe commented Nov 6, 2020

Uh oh!

lilin90 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Nov 6, 2020

Uh oh!

0xPoe commented Nov 9, 2020

Uh oh!

ghost commented Nov 9, 2020

Uh oh!

ghost commented Nov 9, 2020

Uh oh!

ghost commented Nov 9, 2020

Uh oh!

ran-huang commented Nov 9, 2020

Uh oh!

ti-chi-bot commented Nov 9, 2020

Uh oh!

0xPoe commented Nov 9, 2020

Uh oh!

0xPoe commented Nov 9, 2020

Uh oh!

ti-chi-bot commented Nov 9, 2020

Uh oh!

ran-huang commented Nov 12, 2020

Uh oh!

ti-chi-bot commented Nov 12, 2020

Uh oh!

ran-huang commented Nov 12, 2020

Uh oh!

AndreMouche commented Nov 15, 2020

Uh oh!

ran-huang commented Nov 16, 2020

Uh oh!

winkyao left a comment

Choose a reason for hiding this comment

Uh oh!

0xPoe commented Nov 20, 2020

Uh oh!

jackysp left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 23, 2020

Uh oh!

Uh oh!

ran-huang commented Nov 6, 2020 •

edited

Loading

ghost commented Nov 6, 2020 •

edited by ghost

Loading