-
Notifications
You must be signed in to change notification settings - Fork 41
Regenerate core, expose privateHost
and temperature
#348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
austin-denoble
merged 4 commits into
main
from
adenoble/add-privateHost-asst-temperature
Jun 14, 2025
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8162d95
regenerate 2025-04, expose privateHost, add temperature to both ChatO…
austin-denoble a1a8b6f
update chat validations to use the actual enum values in thrown error…
austin-denoble caeaf63
remove unused import
austin-denoble ec768fb
add more retry time to serverless query tests to account for possible…
austin-denoble File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule apis
updated
from a91585 to 827d26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -130,12 +130,15 @@ export const messagesValidation = (options: ChatOptions): MessageModel[] => { | |
* @throws An Error if the model is not one of the available models as outlined in {@link ChatModelEnum}. | ||
*/ | ||
export const modelValidation = (options: ChatOptions) => { | ||
const allowedModels = Object.values(ChatModelEnum); | ||
// Make sure passed string for 'model' matches one of the Enum values; default to Gpt4o | ||
let model: ChatModelEnum = ChatModelEnum.Gpt4o; | ||
if (options.model) { | ||
if (!Object.values(ChatModelEnum).toString().includes(options.model)) { | ||
if (!allowedModels.includes(options.model as ChatModelEnum)) { | ||
throw new Error( | ||
'Invalid model specified. Must be one of "gpt-4o" or "claude-3-5-sonnet"' | ||
`Invalid model specified. Must be one of ${allowedModels | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moving away from hard-coding this. |
||
.map((m) => `"${m}"`) | ||
.join(', ')}:` | ||
); | ||
} else { | ||
model = options.model as ChatModelEnum; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing local runner since the script was moved previously.