Skip to content

Add passkeys support to kernel #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 7, 2024
Merged

Add passkeys support to kernel #340

merged 19 commits into from
Dec 7, 2024

Conversation

plusminushalf
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: c4e394f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
permissionless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 2, 2024

size-limit report 📦

Path Size
permissionless (esm) 48.45 KB (0%)
permissionless (cjs) 216.94 KB (0%)

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 73.04688% with 138 lines in your changes missing coverage. Please review.

Project coverage is 87.43%. Comparing base (edb8baf) to head (c4e394f).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...issionless/accounts/kernel/toKernelSmartAccount.ts 79.40% 82 Missing and 1 partial ⚠️
...ermissionless/accounts/kernel/utils/signMessage.ts 0.00% 39 Missing ⚠️
...missionless/accounts/kernel/utils/signTypedData.ts 38.46% 8 Missing ⚠️
...nless/accounts/kernel/toEcdsaKernelSmartAccount.ts 0.00% 4 Missing ⚠️
packages/permissionless/vitest.config.ts 0.00% 3 Missing ⚠️
...ckages/permissionless/utils/encodeInstallModule.ts 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   89.10%   87.43%   -1.68%     
==========================================
  Files          75       77       +2     
  Lines        6075     6222     +147     
  Branches      361      371      +10     
==========================================
+ Hits         5413     5440      +27     
- Misses        633      753     +120     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plusminushalf plusminushalf merged commit 2ec3ac1 into main Dec 7, 2024
5 of 8 checks passed
@plusminushalf plusminushalf deleted the passkeys branch December 7, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants