Skip to content

Improve 7579 functions #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Improve 7579 functions #289

merged 4 commits into from
Oct 2, 2024

Conversation

plusminushalf
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 6154359

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
permissionless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 94.93333% with 19 lines in your changes missing coverage. Please review.

Project coverage is 88.76%. Comparing base (80176c6) to head (6154359).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/permissionless/utils/encodeInstallModule.ts 90.58% 8 Missing ⚠️
...ages/permissionless/utils/encodeUninstallModule.ts 90.58% 8 Missing ⚠️
...ermissionless/actions/erc7579/isModuleInstalled.ts 88.23% 2 Missing ⚠️
.../permissionless/actions/erc7579/uninstallModule.ts 98.07% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   90.15%   88.76%   -1.40%     
==========================================
  Files          61       63       +2     
  Lines        8341     8517     +176     
  Branches      262      272      +10     
==========================================
+ Hits         7520     7560      +40     
- Misses        821      949     +128     
- Partials        0        8       +8     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plusminushalf plusminushalf merged commit b0ecbbc into main Oct 2, 2024
7 of 9 checks passed
@plusminushalf plusminushalf deleted the improve-7579-functions branch October 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants