Skip to content

0.2 #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
Sep 2, 2024
Merged

0.2 #265

merged 57 commits into from
Sep 2, 2024

Conversation

plusminushalf
Copy link
Member

@plusminushalf plusminushalf commented Aug 13, 2024

Permissionless 0.2 PR is ready. Changes:

  1. createBundlerClient -> in viem now
  2. createPimlicoPaymasterClient -> changed to `createPimlicoClient
  3. createPimlicoBundlerClient -> merged with createPimlicClient
  4. AA errors -> in viem now
  5. privateKeyTo<account-name>SmartAccount -> Not needed (can debate, I have not seen anyone use it)
  6. SmartAccount type -> in viem now
  7. bundler actions -> in viem now
  8. Stackup paymaster actions -> Will add them later again
  9. getEntryPointVersion -> not needed as version is now an integral part of all the functions that has to be passed explicitly.
  10. getUserOperationHash -> in viem now
  11. signUserOperationHashWithECDSA -> i don't see the use of it (can debate to add it back)
  12. These smart account actions:
    • deployContract - viem removed support to allow for encoding custom create 2 factory
    • smartAccount/prepareUserOperationRequest -> in viem now
    • sendTransactions - recommend to use:
      bundlerClient.sendUserOperation({calls: [{to, value, data}, {to, value, data}]})
    • sendUserOperation -> in viem now
    • signerTo<account-name>SmartAccount have now been changed to to<account-name>SmartAccount example: toEcdsaKernelSmartAccount
  13. experimental 7677 -> this is now core part of paymasterClient in viem

I have preserved createSmartAccountClient though it's not needed anymore.
Viem's bundlerClient accepts an account now (our bundlerClient didn't rather smartAccountClient accepted account) so we don't need it.
I preserve it because viem's default bundlerClient doesn't have functions like sendTransaction, singMessage, signTypeData, and writeContract . When we started permissionless we wanted permissionless to an easy drop in replacement. For this to be still true, the client MUST have the above missing functions. To adhere to that philosophy I have kept createSmartAccountClient which adds the above mentioned missing functions to the viem's bundlerClient

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 2e4d504

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
permissionless Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
permissionless (esm) 39.85 KB (0%)
permissionless (cjs) 118.94 KB (0%)
permissionless (minimal surface - tree-shaking) 10.09 KB (0%)

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 88.84254% with 428 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (b045fb4) to head (2e4d504).
Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
...issionless/accounts/simple/toSimpleSmartAccount.ts 73.93% 85 Missing and 1 partial ⚠️
packages/permissionless/accounts/index.ts 0.00% 58 Missing ⚠️
...rmissionless/accounts/light/toLightSmartAccount.ts 86.36% 53 Missing and 1 partial ⚠️
...onless/accounts/biconomy/toBiconomySmartAccount.ts 85.03% 41 Missing ⚠️
...permissionless/accounts/safe/toSafeSmartAccount.ts 92.41% 36 Missing and 2 partials ⚠️
...kages/permissionless/clients/decorators/pimlico.ts 67.79% 19 Missing ⚠️
...rmissionless/accounts/trust/toTrustSmartAccount.ts 91.96% 18 Missing ⚠️
...issionless/actions/smartAccount/sendTransaction.ts 75.86% 14 Missing ⚠️
...nless/accounts/kernel/toEcdsaKernelSmartAccount.ts 93.46% 12 Missing and 1 partial ⚠️
...issionless/actions/pimlico/sponsorUserOperation.ts 82.19% 13 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   85.21%   88.94%   +3.72%     
==========================================
  Files         109       61      -48     
  Lines       14032     8297    -5735     
  Branches      407      252     -155     
==========================================
- Hits        11958     7380    -4578     
+ Misses       2068      910    -1158     
- Partials        6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plusminushalf plusminushalf changed the title [WIP] 0.2 0.2 Aug 21, 2024
@plusminushalf plusminushalf merged commit c605cb5 into main Sep 2, 2024
5 of 6 checks passed
@plusminushalf plusminushalf deleted the v0.2 branch September 2, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants