-
Notifications
You must be signed in to change notification settings - Fork 77
0.2 #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
0.2 #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2e4d504 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
kristofgazso
approved these changes
Aug 26, 2024
fix v07 prefund calculations
…6 as we default to entrypoint 0.7
Feat/erc20 paymaster actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permissionless 0.2 PR is ready. Changes:
createBundlerClient
-> in viem nowcreatePimlicoPaymasterClient
-> changed to `createPimlicoClientcreatePimlicClient
privateKeyTo<account-name>SmartAccount
-> Not needed (can debate, I have not seen anyone use it)SmartAccount
type -> in viem nowgetEntryPointVersion
-> not needed as version is now an integral part of all the functions that has to be passed explicitly.getUserOperationHash
-> in viem nowsignUserOperationHashWithECDSA
-> i don't see the use of it (can debate to add it back)deployContract
- viem removed support to allow for encoding custom create 2 factorysmartAccount/prepareUserOperationRequest
-> in viem nowsendTransactions
- recommend to use:bundlerClient.sendUserOperation({calls: [{to, value, data}, {to, value, data}]})
sendUserOperation
-> in viem nowsignerTo<account-name>SmartAccount
have now been changed toto<account-name>SmartAccount
example:toEcdsaKernelSmartAccount
I have preserved
createSmartAccountClient
though it's not needed anymore.Viem's bundlerClient accepts an account now (our
bundlerClient
didn't rathersmartAccountClient
accepted account) so we don't need it.I preserve it because viem's default
bundlerClient
doesn't have functions likesendTransaction, singMessage, signTypeData, and writeContract
. When we started permissionless we wanted permissionless to an easy drop in replacement. For this to be still true, the client MUST have the above missing functions. To adhere to that philosophy I have keptcreateSmartAccountClient
which adds the above mentioned missing functions to the viem'sbundlerClient