Skip to content

Remove public actions requirement and loose smart account type #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

plusminushalf
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: b5f998a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
permissionless (esm) 39.85 KB (0%)
permissionless (cjs) 118.94 KB (0%)
permissionless (minimal surface - tree-shaking) 10.09 KB (0%)

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 33 lines in your changes missing coverage. Please review.

Project coverage is 84.75%. Comparing base (8d9bb44) to head (b5f998a).
Report is 6 commits behind head on main.

Files Patch % Lines
.../permissionless/clients/decorators/smartAccount.ts 42.22% 26 Missing ⚠️
...ermissionless/actions/erc7579/isModuleInstalled.ts 72.22% 5 Missing ⚠️
...missionless/actions/smartAccount/deployContract.ts 93.33% 1 Missing ⚠️
...rmissionless/actions/smartAccount/writeContract.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   85.20%   84.75%   -0.45%     
==========================================
  Files         109      109              
  Lines       13996    13692     -304     
  Branches      407      407              
==========================================
- Hits        11925    11605     -320     
- Misses       2065     2081      +16     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant