Skip to content

fix: domain typing #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 9, 2024
Merged

fix: domain typing #221

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
88de41e
fix: domain typing
cdirks4 Jun 7, 2024
0bcaa27
fix: remove comment
cdirks4 Jun 7, 2024
7dde111
create changeset
cdirks4 Jun 7, 2024
6585394
fix: domain should still be and object
cdirks4 Jun 7, 2024
b6117f8
fix: update change log
cdirks4 Jun 7, 2024
f9c3d8e
Merge branch 'main' of github.com:pimlicolabs/permissionless.js into …
plusminushalf Jun 9, 2024
54c14cb
Lint
plusminushalf Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-trainers-sit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"permissionless": patch
---

fix: domain typing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change to Fixed domain not typed as TypedDataDomain

Copy link
Contributor Author

@cdirks4 cdirks4 Jun 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. First open source commit, I will be more specific in the future.

4 changes: 2 additions & 2 deletions packages/permissionless/actions/smartAccount/signTypedData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
type Transport,
type TypedData,
type TypedDataDefinition,
type TypedDataDomain,
getTypesForEIP712Domain,
validateTypedData
} from "viem"
Expand Down Expand Up @@ -136,10 +137,9 @@ export async function signTypedData<
const account = parseAccount(account_)

const types = {
EIP712Domain: getTypesForEIP712Domain({ domain }),
EIP712Domain: getTypesForEIP712Domain(domain as {domain: TypedDataDomain}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't parameter still be

EIP712Domain: getTypesForEIP712Domain({domain} as {domain: TypedDataDomain}),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep /:

...(types_ as TTypedData)
}

validateTypedData({
domain,
message,
Expand Down
Loading