Skip to content

Attribute #[AutowiredService] for slimmer config.neon #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,21 @@ jobs:
coverage: "none"
php-version: "${{ matrix.php-version }}"


- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
run: |
composer global require --dev ondrejmirtes/simple-downgrader:^2.0
echo "$(composer global config bin-dir --absolute -q)" >> "$GITHUB_PATH"
simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}


- name: "Validate Composer"
run: "composer validate"

- name: "Install dependencies"
run: "composer install --no-interaction --no-progress"

- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"

- name: "Lint"
run: "make lint"

Expand Down
24 changes: 14 additions & 10 deletions .github/workflows/reflection-golden-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,15 @@ jobs:
ini-file: development
ini-values: memory_limit=2G

- name: "Install dependencies"
run: "composer install --no-interaction --no-progress"

- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
shell: bash
run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"
run: |
composer global require --dev ondrejmirtes/simple-downgrader:^2.0
echo "$(composer global config bin-dir --absolute -q)" >> "$GITHUB_PATH"
simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}

- name: "Install dependencies"
run: "composer install --no-interaction --no-progress"

- name: "Dump previous reflection data"
run: "php tests/generate-reflection-test.php"
Expand All @@ -115,13 +117,15 @@ jobs:
- name: "Checkout"
uses: actions/checkout@v4

- name: "Install dependencies"
run: "composer install --no-interaction --no-progress"

- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
shell: bash
run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"
run: |
composer global require --dev ondrejmirtes/simple-downgrader:^2.0
echo "$(composer global config bin-dir --absolute -q)" >> "$GITHUB_PATH"
simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}

- name: "Install dependencies"
run: "composer install --no-interaction --no-progress"

- name: "Reflection golden test"
run: "make tests-golden-reflection || true"
11 changes: 7 additions & 4 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,16 @@ jobs:
ini-file: development
extensions: mbstring

- name: "Install dependencies"
run: "composer install --no-interaction --no-progress"

- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
shell: bash
run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"
run: |
composer global require --dev ondrejmirtes/simple-downgrader:^2.0
echo "$(composer global config bin-dir --absolute -q)" >> "$GITHUB_PATH"
simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}

- name: "Install dependencies"
run: "composer install --no-interaction --no-progress"

- name: "PHPStan"
run: "make phpstan"
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,16 @@ jobs:
ini-file: development
ini-values: memory_limit=2G

- name: "Install dependencies"
run: "composer install --no-interaction --no-progress"

- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
shell: bash
run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"
run: |
composer global require --dev ondrejmirtes/simple-downgrader:^2.0
echo "$(composer global config bin-dir --absolute -q)" >> "$GITHUB_PATH"
simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}

- name: "Install dependencies"
run: "composer install --no-interaction --no-progress"

- name: "Tests"
run: "make tests"
Expand Down
3 changes: 2 additions & 1 deletion compiler/build/box.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
],
"files": [
"preload.php",
"vendor/composer/installed.php"
"vendor/composer/installed.php",
"vendor/attributes.php"
],
"directories": [
"conf",
Expand Down
9 changes: 5 additions & 4 deletions compiler/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@
"require": {
"php": "^8.0",
"nette/neon": "^3.0.0",
"ondrejmirtes/simple-downgrader": "^2.0",
"seld/phar-utils": "^1.2",
"symfony/console": "^6.0.0",
"symfony/filesystem": "^6.0.0",
"symfony/finder": "^6.0.0",
"symfony/process": "^6.0.0"
"symfony/console": "^5.4.43",
"symfony/filesystem": "^5.4.43",
"symfony/finder": "^5.4.43",
"symfony/process": "^5.4.43"
},
"autoload": {
"psr-4": {
Expand Down
Loading
Loading