Revert "non-falsy-string cannot be converted to 0" #3997
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f615b1a.
mvorisek
reviewed
May 16, 2025
|
Friendly ping @ondrejmirtes This PR might be forgotten since I assume it's a quick review.
|
Please add a test for this case so we see it next time earlier |
How do you want to add such test ? There is already a test checking that (int) non-falsy-string is an int (and I added a comment). If I add a test for the special case '00' it will be useless since the methode used will be from ConstantStringType and not AccessoryNonFalsyStringType |
|
I see, thanks for looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f615b1a.