Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while finishing #3952
Edge cases fixed here:
array_slice($array, 0, <positive int>)
with a non-empty-array as input will also return a non-empty array because we don't know which of the keys is set. That only can be done for a non-empty-list. The last test change shows this nicelyImprovement:
array_slice
with length set to 0 will always returnarray{}
Bug fix:
array_slice
with negative offset and negative length of the same value or smaller will always returnarray{}