Skip to content

PlatformTest: drop MSSQL database asserts #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from
Open

PlatformTest: drop MSSQL database asserts #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/workflows/platform-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ jobs:
env:
MYSQL_HOST: '127.0.0.1'
PGSQL_HOST: '127.0.0.1'
MSSQL_HOST: '127.0.0.1'

strategy:
fail-fast: false
Expand Down Expand Up @@ -83,12 +82,3 @@ jobs:
MYSQL_DATABASE: foo
ports:
- "3306:3306"

mssql:
image: mcr.microsoft.com/mssql/server:latest
env:
ACCEPT_EULA: Y
SA_PASSWORD: 'Secret.123'
MSSQL_PID: Developer
ports:
- 1433:1433
40 changes: 0 additions & 40 deletions tests/Platform/QueryResultTypeWalkerFetchTypeMatrixTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,46 +541,6 @@
);
}

/**
* @param array<string, mixed> $data
* @param mixed $mysqlExpectedResult
* @param mixed $sqliteExpectedResult
* @param mixed $pdoPgsqlExpectedResult
* @param mixed $pgsqlExpectedResult
* @param mixed $mssqlExpectedResult
* @param self::STRINGIFY_* $stringify
*
* @dataProvider provideCases
*/
public function testUnsupportedDriver(
array $data,
string $dqlTemplate,
Type $mysqlExpectedType,
?Type $sqliteExpectedType,
?Type $pdoPgsqlExpectedType,
?Type $pgsqlExpectedType,
?Type $mssqlExpectedType,
$mysqlExpectedResult,
$sqliteExpectedResult,
$pdoPgsqlExpectedResult,
$pgsqlExpectedResult,
$mssqlExpectedResult,
string $stringify
): void
{
$this->performDriverTest(
'sqlsrv',
self::CONFIG_DEFAULT,
$data,
$dqlTemplate,
(string) $this->dataName(),
PHP_VERSION_ID,
$mssqlExpectedType,
$mssqlExpectedResult,
$stringify,
);
}

/**
* @param array<string, mixed> $data
* @param mixed $mysqlExpectedResult
Expand Down Expand Up @@ -5139,7 +5099,7 @@
if (InstalledVersions::satisfies(new VersionParser(), 'doctrine/orm', '3.*')) {
$config->setMetadataDriverImpl(new AttributeDriver([__DIR__ . '/Entity']));
} else {
$config->setMetadataDriverImpl(new AnnotationDriver(new AnnotationReader(), [__DIR__ . '/Entity']));

Check failure on line 5102 in tests/Platform/QueryResultTypeWalkerFetchTypeMatrixTest.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.3, composer require --dev doctrine/orm:^3.0 doctrine/dbal:^4.0 carbonphp/carbon-doctri... 

Instantiation of deprecated class Doctrine\ORM\Mapping\Driver\AnnotationDriver:
This class will be removed in 3.0 without replacement.
Copyright (c) Doctrine Project
From https://github.com/doctrine/orm/blob/40fbbf4429b0d66517244051237a2bd0616a7a13/src/Mapping/Driver/AnnotationDriver.php

Check failure on line 5102 in tests/Platform/QueryResultTypeWalkerFetchTypeMatrixTest.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.3, composer require --dev doctrine/orm:^3.0 doctrine/dbal:^4.0 carbonphp/carbon-doctri... 

Call to method __construct() of deprecated class Doctrine\ORM\Mapping\Driver\AnnotationDriver:
This class will be removed in 3.0 without replacement.
Copyright (c) Doctrine Project
From https://github.com/doctrine/orm/blob/40fbbf4429b0d66517244051237a2bd0616a7a13/src/Mapping/Driver/AnnotationDriver.php
}

$config->addCustomStringFunction('INT_PI', TypedExpressionIntegerPiFunction::class);
Expand Down
12 changes: 0 additions & 12 deletions tests/Platform/docker/Dockerfile80
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
FROM php:8.0-cli

# MSSQL
RUN apt update \
&& apt install -y gnupg2 \
&& apt install -y unixodbc-dev unixodbc \
&& curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - \
&& curl https://packages.microsoft.com/config/debian/11/prod.list > /etc/apt/sources.list.d/mssql-release.list \
&& apt update \
&& ACCEPT_EULA=Y apt install -y msodbcsql17 \
&& pecl install sqlsrv-5.11.1 \
&& pecl install pdo_sqlsrv-5.11.1 \
&& docker-php-ext-enable sqlsrv pdo_sqlsrv

COPY ./docker-setup.sh /opt/src/scripts/setup.sh
RUN /opt/src/scripts/setup.sh

Expand Down
12 changes: 0 additions & 12 deletions tests/Platform/docker/Dockerfile81
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
FROM php:8.1-cli

# MSSQL
RUN apt update \
&& apt install -y gnupg2 \
&& apt install -y unixodbc-dev unixodbc \
&& curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - \
&& curl https://packages.microsoft.com/config/ubuntu/20.04/prod.list | tee /etc/apt/sources.list.d/mssql-tools.list \
&& apt update \
&& ACCEPT_EULA=Y apt install -y msodbcsql17 \
&& pecl install sqlsrv \
&& pecl install pdo_sqlsrv \
&& docker-php-ext-enable sqlsrv pdo_sqlsrv

COPY ./docker-setup.sh /opt/src/scripts/setup.sh
RUN /opt/src/scripts/setup.sh

Expand Down
12 changes: 0 additions & 12 deletions tests/Platform/docker/Dockerfile84
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
FROM php:8.4-cli

# MSSQL
RUN apt update \
&& apt install -y gnupg2 \
&& apt install -y unixodbc-dev unixodbc \
&& curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - \
&& curl https://packages.microsoft.com/config/ubuntu/20.04/prod.list | tee /etc/apt/sources.list.d/mssql-tools.list \
&& apt update \
&& ACCEPT_EULA=Y apt install -y msodbcsql17 \
&& pecl install sqlsrv \
&& pecl install pdo_sqlsrv \
&& docker-php-ext-enable sqlsrv pdo_sqlsrv

COPY ./docker-setup.sh /opt/src/scripts/setup.sh
RUN /opt/src/scripts/setup.sh

Expand Down
14 changes: 1 addition & 13 deletions tests/Platform/docker/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,24 +27,14 @@ services:
type: tmpfs
target: /var/lib/postgresql/data

mssql:
image: mcr.microsoft.com/mssql/server:latest
environment:
ACCEPT_EULA: Y
SA_PASSWORD: 'Secret.123'
MSSQL_PID: Developer
ports:
- 1433:1433

php80:
depends_on: [mysql, pgsql, mssql]
depends_on: [mysql, pgsql]
build:
context: .
dockerfile: ./Dockerfile80
environment:
MYSQL_HOST: mysql
PGSQL_HOST: pgsql
MSSQL_HOST: mssql
working_dir: /app
user: ${UID:-1000}:${GID:-1000}
volumes:
Expand All @@ -58,7 +48,6 @@ services:
environment:
MYSQL_HOST: mysql
PGSQL_HOST: pgsql
MSSQL_HOST: mssql
working_dir: /app
user: ${UID:-1000}:${GID:-1000}
volumes:
Expand All @@ -72,7 +61,6 @@ services:
environment:
MYSQL_HOST: mysql
PGSQL_HOST: pgsql
MSSQL_HOST: mssql
working_dir: /app
user: ${UID:-1000}:${GID:-1000}
volumes:
Expand Down
2 changes: 1 addition & 1 deletion tests/Platform/docker/docker-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -ex \
&& apt update \
&& apt install -y bash zip libpq-dev libsqlite3-dev \
&& pecl install xdebug mongodb \
&& pecl install xdebug mongodb-1.19.4 \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer versions are incompatible with PHP 8.0

&& docker-php-ext-configure pgsql -with-pgsql=/usr/local/pgsql \
&& docker-php-ext-install pdo mysqli pgsql pdo_mysql pdo_pgsql pdo_sqlite \
&& docker-php-ext-enable xdebug mongodb
Loading